Skip to content

collapse error pane by default #11199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riknoll merged 2 commits into from
Mar 18, 2026
+7 −6
Merged

collapse error pane by default #11199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76e6b1
collapse error pane by default
riknoll Mar 18, 2026
8e94d65
rename prop
riknoll Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion localtypings/pxteditor.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ declare namespace pxt.editor {
simSerialActive?: boolean;
deviceSerialActive?: boolean;
errorListState?: ErrorListState;
errorListCollapsedByUser?: boolean;
errorListCollapsed?: boolean;
screenshoting?: boolean;
extensionsVisible?: boolean;
isMultiplayerGame?: boolean; // Arcade: Does the current project contain multiplayer blocks?
Expand Down
3 changes: 2 additions & 1 deletion webapp/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ export class ProjectView
isMultiplayerGame: false,
activeTourConfig: undefined,
mute: pxt.editor.MuteState.Unmuted,
feedback: {showing: false, kind: "generic"} // state that tracks if the feedback modal is showing and what kind
feedback: {showing: false, kind: "generic"}, // state that tracks if the feedback modal is showing and what kind
errorListCollapsed: true // error pane is collapsed by default
};
if (!this.settings.editorFontSize) this.settings.editorFontSize = /mobile/i.test(navigator.userAgent) ? 15 : 19;
if (!this.settings.fileHistory) this.settings.fileHistory = [];
Expand Down
4 changes: 2 additions & 2 deletions webapp/src/blocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {
<ErrorList
errors={this.errors}
onSizeChange={this.onErrorListResize}
collapsedByUser={this.parent.state.errorListCollapsedByUser}
collapsedByUser={this.parent.state.errorListCollapsed}
onUserCollapse={this.setErrorListCollapsePreference}
getErrorHelp={this.getErrorHelp}
showLoginDialog={this.parent.showLoginDialog}
Expand All @@ -1122,7 +1122,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {

protected setErrorListCollapsePreference = (collapsed: boolean) => {
this.parent.setState({
errorListCollapsedByUser: collapsed
errorListCollapsed: collapsed
});
}

Expand Down
4 changes: 2 additions & 2 deletions webapp/src/monaco.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {
{showErrorList && (
<ErrorList
onSizeChange={this.setErrorListState}
collapsedByUser={this.parent.state.errorListCollapsedByUser}
collapsedByUser={this.parent.state.errorListCollapsed}
onUserCollapse={this.setErrorListCollapsePreference}
errors={this.errors}
startDebugger={this.startDebugger}
Expand Down Expand Up @@ -963,7 +963,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {

protected setErrorListCollapsePreference = (collapsed: boolean) => {
this.parent.setState({
errorListCollapsedByUser: collapsed
errorListCollapsed: collapsed
});
}

Expand Down
Loading