Add ariaDisabled prop to button#11236
Merged
Merged
Conversation
aria-disabled uses the ariaDisabled or disabled props to inform screen readers that the button is dimmed or unavailable etc. Remove title from undo / redo buttons as aria-label is present.
riknoll
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sui button component now has an
aria-disabledattribute which uses the newariaDisabledprop or existingdisabledprop to inform screen readers that the button is dimmed or unavailable (language dependent on the screen reader used). Although the buttonaria-labelsometimes has text to inform the user that it is disabled, this is a standard practice approach and will catch instances of where this labelling has been missed.Remove title from undo / redo buttons as aria-label is present (this avoids output such as "Redo Disabled, Redo") and make use of new
ariaDisabledprop.