hide modal siblings from screen reader#11247
Merged
Merged
Conversation
srietkerk
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-microbit#6740
this PR does two things:
the first change effectively undoes this one because it's no longer necessary; at some point in the theme work we moved the .hc class up to the document body so modals no longer need to be within root to get the high contrast css
the second change addresses the actual issue. while i don't love it (feels kind of hacky) this seemed like the most elegant way to have this behavior immediately reflected in all of our webapps without having to pass an array of elements into each instance of the Modal component. hiding just the #content div was probably insufficient anyhow since there are other children of document.body that could contain interactable elements like Blockly's widgetdiv and dropdowndiv
@microbit-matt-hillsdon @microbit-robert FYI