Skip to content

Fix broken Twitter follow link in documentation footer #11273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix broken Twitter follow link in documentation footer #11273

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b0da2f
Initial plan
Copilot Apr 16, 2026
6a91444
Fix broken Twitter follow link in documentation footer
Copilot Apr 16, 2026
585f655
Merge branch 'master' into copilot/fix-footer-icon-404-error
abchatra Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docfiles/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<div class="ui horizontal link list">
<a
class="item"
href="https://twitter.com/intent/follow?screen_name=MsMakeCode"
title="Follow us on Twitter"
href="https://x.com/MsMakeCode"
title="Follow us on X"
Comment on lines +6 to +7
Copy link
Copy Markdown
Member

@jwunderl jwunderl May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
href="https://x.com/MsMakeCode"
title="Follow us on X"
href="https://x.com/intent/follow?screen_name=MsMakeCode"
title="Follow us on X"

missed this pr before but it looks like the intent/follow is still working on my end? goes to a sign in screen if not logged in, but ends up at a modal overlaid over msmakecode that has follow option.

looks like even if not signed in x.com/MsMakeCode is fine though, so okay either way -- suggested change retains current behavior / as written works better for non signed in users

target="_blank"
rel="noopener">
<i class="huge icon twitter"></i>
Expand Down
Loading