remove hex info packaging#11425
Merged
Merged
Conversation
Collaborator
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ran into an issue where in some cases this failed to load back in hex file to app because the hex file writer was only writing bottom 16 bits instead of all 32; it was already a side feature so just removing, packaged extensions should still load just fine but won't be able to download until internet for full hex info. hex file was also noticeably increasing size of full hex, so just doesn't feel worth it -- it would have already been a bit of a stretch as would have required exact cpp match (e.g. if there was a 1 character change on live site vs latest offline app would have failed), so fine to cut, rather than dealing with weird stuff here.
The part that i committed & reverted does work, and should be fine, but is not necessary with the hexfile portion culled / don't see a reason to actually merge it and have to think about it. put it in here just in case so can have the exact change if it does need to be updated, for any reason
(this pr is purely deleting code added in #11342)