Skip to content

Commit 870edd1

Browse files
fix style (#11390)
1 parent 28ea84a commit 870edd1

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

  • packages/pyright-internal/src/analyzer

packages/pyright-internal/src/analyzer/binder.ts

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1209,24 +1209,6 @@ export class Binder extends ParseTreeWalker {
12091209
return false;
12101210
}
12111211

1212-
// Helper method to determine if an expression is a non-empty list or tuple literal.
1213-
// This is a syntactic check, not a semantic one, so it's very fast.
1214-
// Guards against starred expressions ([*empty_list]) and comprehensions ([v for v in []]).
1215-
private _isNonEmptyListOrTupleLiteral(expr: ExpressionNode): boolean {
1216-
if (expr.nodeType === ParseNodeType.List) {
1217-
return (
1218-
expr.d.items.length > 0 &&
1219-
expr.d.items.every(
1220-
(item) => item.nodeType !== ParseNodeType.Unpack && item.nodeType !== ParseNodeType.Comprehension
1221-
)
1222-
);
1223-
}
1224-
if (expr.nodeType === ParseNodeType.Tuple) {
1225-
return expr.d.items.length > 0 && expr.d.items.every((item) => item.nodeType !== ParseNodeType.Unpack);
1226-
}
1227-
return false;
1228-
}
1229-
12301212
override visitFor(node: ForNode) {
12311213
this._bindPossibleTupleNamedTarget(node.d.targetExpr);
12321214
this._addInferredTypeAssignmentForVariable(node.d.targetExpr, node);
@@ -2502,6 +2484,24 @@ export class Binder extends ParseTreeWalker {
25022484
return true;
25032485
}
25042486

2487+
// Helper method to determine if an expression is a non-empty list or tuple literal.
2488+
// This is a syntactic check, not a semantic one, so it's very fast.
2489+
// Guards against starred expressions ([*empty_list]) and comprehensions ([v for v in []]).
2490+
private _isNonEmptyListOrTupleLiteral(expr: ExpressionNode): boolean {
2491+
if (expr.nodeType === ParseNodeType.List) {
2492+
return (
2493+
expr.d.items.length > 0 &&
2494+
expr.d.items.every(
2495+
(item) => item.nodeType !== ParseNodeType.Unpack && item.nodeType !== ParseNodeType.Comprehension
2496+
)
2497+
);
2498+
}
2499+
if (expr.nodeType === ParseNodeType.Tuple) {
2500+
return expr.d.items.length > 0 && expr.d.items.every((item) => item.nodeType !== ParseNodeType.Unpack);
2501+
}
2502+
return false;
2503+
}
2504+
25052505
private _addTypingImportAliasesFromBuiltinsScope() {
25062506
if (!this._fileInfo.builtinsScope) {
25072507
return;

0 commit comments

Comments
 (0)