Fix repetitive clippy patterns: needless struct updates, useless conversions, assert_eq with bool

Co-authored-by: karthiknadig <3840081+karthiknadig@users.noreply.github.com>

Author: Copilot

crates/pet-poetry/src/config.rs

@@ -242,7 +242,7 @@ create = false
 "#;
 
         assert_eq!(
-            parse_contents(&cfg.to_string())
+            parse_contents(cfg)
                 .unwrap()
                 .virtualenvs_in_project
                 .unwrap_or_default(),
@@ -256,7 +256,7 @@ create = false
 
 "#;
         assert_eq!(
-            parse_contents(&cfg.to_string())
+            parse_contents(cfg)
                 .unwrap()
                 .virtualenvs_in_project
                 .unwrap_or_default(),
@@ -269,7 +269,7 @@ create = false
 
 "#;
         assert_eq!(
-            parse_contents(&cfg.to_string())
+            parse_contents(cfg)
                 .unwrap()
                 .virtualenvs_in_project
                 .unwrap_or_default(),
@@ -279,22 +279,20 @@ create = false
         let cfg = r#"
 virtualenvs.in-project = true # comment
 "#;
-        assert_eq!(
-            parse_contents(&cfg.to_string())
+        assert!(
+            parse_contents(&cfg)
                 .unwrap()
                 .virtualenvs_in_project
-                .unwrap_or_default(),
-            true
+                .unwrap_or_default()
         );
 
         let cfg = r#"
 "#;
-        assert_eq!(
-            parse_contents(&cfg.to_string())
+        assert!(
+            !parse_contents(&cfg)
                 .unwrap()
                 .virtualenvs_in_project
-                .unwrap_or_default(),
-            false
+                .unwrap_or_default()
         );
     }
 
@@ -305,15 +303,15 @@ cache-dir = "/path/to/cache/directory"
 
 "#;
         assert_eq!(
-            parse_contents(&cfg.to_string()).unwrap().cache_dir,
+            parse_contents(cfg).unwrap().cache_dir,
             Some(PathBuf::from("/path/to/cache/directory".to_string()))
         );
 
         let cfg = r#"
 some-other-value = 1234
 
 "#;
-        assert_eq!(parse_contents(&cfg.to_string()).unwrap().cache_dir, None);
+        assert_eq!(parse_contents(cfg).unwrap().cache_dir, None);
     }
 
     #[test]
@@ -323,7 +321,7 @@ virtualenvs.path = "/path/to/virtualenvs"
 
 "#;
         assert_eq!(
-            parse_contents(&cfg.to_string()).unwrap().virtualenvs_path,
+            parse_contents(cfg).unwrap().virtualenvs_path,
             Some(PathBuf::from("/path/to/virtualenvs".to_string()))
         );
 
@@ -332,7 +330,7 @@ some-other-value = 1234
 
 "#;
         assert_eq!(
-            parse_contents(&cfg.to_string()).unwrap().virtualenvs_path,
+            parse_contents(cfg).unwrap().virtualenvs_path,
             None
         );
     }
@@ -343,7 +341,7 @@ some-other-value = 1234
 cache-dir = "/path/to/cache/directory"
 "#;
         assert_eq!(
-            parse_contents(&cfg.to_string()).unwrap().virtualenvs_path,
+            parse_contents(cfg).unwrap().virtualenvs_path,
             Some(PathBuf::from("/path/to/cache/directory/virtualenvs"))
         );
     }

crates/pet-poetry/src/pyproject_toml.rs

@@ -90,7 +90,7 @@ requires = ["poetry-core"]
 build-backend = "poetry.core.masonry.api"
 "#;
         assert_eq!(
-            parse_contents(&cfg.to_string(), Path::new("pyproject.toml"))
+            parse_contents(cfg, Path::new("pyproject.toml"))
                 .unwrap()
                 .name,
             "poetry-demo"

crates/pet-pyenv/tests/common.rs

@@ -34,27 +34,29 @@ pub struct TestEnvironment {
     root: Option<PathBuf>,
     globals_locations: Vec<PathBuf>,
 }
+
+impl Environment for TestEnvironment {
+    fn get_env_var(&self, key: String) -> Option<String> {
+        self.vars.get(&key).cloned()
+    }
+    fn get_root(&self) -> Option<PathBuf> {
+        self.root.clone()
+    }
+    fn get_user_home(&self) -> Option<PathBuf> {
+        self.home.clone()
+    }
+    fn get_know_global_search_locations(&self) -> Vec<PathBuf> {
+        self.globals_locations.clone()
+    }
+}
+
 #[allow(dead_code)]
 pub fn create_test_environment(
     vars: HashMap<String, String>,
     home: Option<PathBuf>,
     globals_locations: Vec<PathBuf>,
     root: Option<PathBuf>,
 ) -> TestEnvironment {
-    impl Environment for TestEnvironment {
-        fn get_env_var(&self, key: String) -> Option<String> {
-            self.vars.get(&key).cloned()
-        }
-        fn get_root(&self) -> Option<PathBuf> {
-            self.root.clone()
-        }
-        fn get_user_home(&self) -> Option<PathBuf> {
-            self.home.clone()
-        }
-        fn get_know_global_search_locations(&self) -> Vec<PathBuf> {
-            self.globals_locations.clone()
-        }
-    }
     TestEnvironment {
         vars,
         home,

crates/pet-pyenv/tests/pyenv_test.rs

@@ -29,8 +29,8 @@ fn does_not_find_any_pyenv_envs() {
     let environments = reporter.environments.lock().unwrap().clone();
     let managers = reporter.managers.lock().unwrap().clone();
 
-    assert_eq!(managers.is_empty(), true);
-    assert_eq!(environments.is_empty(), true);
+    assert!(managers.is_empty());
+    assert!(environments.is_empty());
 }
 
 #[test]
@@ -63,7 +63,7 @@ fn does_not_find_any_pyenv_envs_even_with_pyenv_installed() {
     let environment = create_test_environment(
         HashMap::new(),
         Some(home.clone()),
-        vec![PathBuf::from(homebrew_bin)],
+        vec![homebrew_bin],
         None,
     );
 
@@ -119,7 +119,7 @@ fn find_pyenv_envs() {
     let environment = create_test_environment(
         HashMap::new(),
         Some(home.clone()),
-        vec![PathBuf::from(homebrew_bin)],
+        vec![homebrew_bin],
         None,
     );