fix formatting

Author: karthiknadig

.github/copilot-instructions.md

@@ -127,8 +127,8 @@ Tests validate discovered environments using 4 verification methods:
 3. `crates/pet-core/src/lib.rs` - Essential traits and types
 4. `crates/pet/tests/ci_test.rs` - Comprehensive testing patterns
 
-
 ## Scripts
+
 - Use `cargo fetch` to download all dependencies
 - Use `rustup component add clippy` to install Clippy linter
 - Use `cargo fmt --all` to format code in all packages
@@ -137,3 +137,17 @@ Tests validate discovered environments using 4 verification methods:
 - Use `cargo test [TESTNAME]` to test a specific test
 - Use `cargo test -p [SPEC]` to test a specific package
 - Use `cargo test --all` to test all packages
+
+## Required Before Committing
+
+**ALWAYS run these commands before committing any Rust code changes:**
+
+```bash
+# Format all code (required)
+cargo fmt --all
+
+# Run clippy with warnings as errors (required)
+cargo clippy --all -- -D warnings
+```
+
+If clippy reports warnings, fix them before committing. Do not use `#[allow(...)]` attributes to suppress warnings unless absolutely necessary and justified.

crates/pet/tests/e2e_performance.rs

@@ -518,7 +518,10 @@ fn test_server_startup_performance() {
     let cache_dir = get_test_cache_dir();
     let workspace_dir = get_workspace_dir();
 
-    println!("=== Server Startup Performance ({} iterations) ===", STAT_ITERATIONS);
+    println!(
+        "=== Server Startup Performance ({} iterations) ===",
+        STAT_ITERATIONS
+    );
 
     for i in 0..STAT_ITERATIONS {
         let start = Instant::now();
@@ -586,7 +589,10 @@ fn test_full_refresh_performance() {
     let cache_dir = get_test_cache_dir();
     let workspace_dir = get_workspace_dir();
 
-    println!("=== Full Refresh Performance ({} iterations) ===", STAT_ITERATIONS);
+    println!(
+        "=== Full Refresh Performance ({} iterations) ===",
+        STAT_ITERATIONS
+    );
 
     for i in 0..STAT_ITERATIONS {
         // Fresh server each iteration for consistent cold-start measurement
@@ -671,7 +677,10 @@ fn test_workspace_scoped_refresh_performance() {
     let cache_dir = get_test_cache_dir();
     let workspace_dir = get_workspace_dir();
 
-    println!("=== Workspace-Scoped Refresh Performance ({} iterations) ===", STAT_ITERATIONS);
+    println!(
+        "=== Workspace-Scoped Refresh Performance ({} iterations) ===",
+        STAT_ITERATIONS
+    );
 
     for i in 0..STAT_ITERATIONS {
         let mut client = PetClient::spawn().expect("Failed to spawn server");
@@ -727,7 +736,10 @@ fn test_kind_specific_refresh_performance() {
     // Test different environment kinds
     let kinds = ["Conda", "Venv", "VirtualEnv", "Pyenv"];
 
-    println!("=== Kind-Specific Refresh Performance ({} iterations per kind) ===", STAT_ITERATIONS);
+    println!(
+        "=== Kind-Specific Refresh Performance ({} iterations per kind) ===",
+        STAT_ITERATIONS
+    );
 
     let mut all_kind_stats: HashMap<String, Value> = HashMap::new();
 
@@ -789,7 +801,10 @@ fn test_resolve_performance() {
     let cache_dir = get_test_cache_dir();
     let workspace_dir = get_workspace_dir();
 
-    println!("=== Resolve Performance ({} iterations) ===", STAT_ITERATIONS);
+    println!(
+        "=== Resolve Performance ({} iterations) ===",
+        STAT_ITERATIONS
+    );
 
     // First, find an executable to test with (use a single server)
     let exe_to_test: String;
@@ -829,7 +844,9 @@ fn test_resolve_performance() {
         });
         client.configure(config).expect("Failed to configure");
 
-        let (_, cold_time) = client.resolve(&exe_to_test).expect("Failed to resolve (cold)");
+        let (_, cold_time) = client
+            .resolve(&exe_to_test)
+            .expect("Failed to resolve (cold)");
         cold_resolve_stats.add(cold_time.as_millis());
         println!("    Iteration {}: {}ms", i + 1, cold_time.as_millis());
     }
@@ -848,7 +865,9 @@ fn test_resolve_performance() {
         client.resolve(&exe_to_test).expect("Failed to prime cache");
 
         for i in 0..STAT_ITERATIONS {
-            let (_, warm_time) = client.resolve(&exe_to_test).expect("Failed to resolve (warm)");
+            let (_, warm_time) = client
+                .resolve(&exe_to_test)
+                .expect("Failed to resolve (warm)");
             warm_resolve_stats.add(warm_time.as_millis());
             println!("    Iteration {}: {}ms", i + 1, warm_time.as_millis());
         }
@@ -861,7 +880,10 @@ fn test_resolve_performance() {
     // Calculate speedup
     if let (Some(cold_p50), Some(warm_p50)) = (cold_resolve_stats.p50(), warm_resolve_stats.p50()) {
         if warm_p50 > 0 {
-            println!("Cache speedup (P50): {:.2}x", cold_p50 as f64 / warm_p50 as f64);
+            println!(
+                "Cache speedup (P50): {:.2}x",
+                cold_p50 as f64 / warm_p50 as f64
+            );
         }
     }