test: address pet-homebrew review comments (PR #394)

Author: karthiknadig

crates/pet-homebrew/Cargo.toml

@@ -19,3 +19,6 @@ pet-core = { path = "../pet-core" }
 log = "0.4.21"
 regex = "1.10.4"
 rayon = "1.11.0"
+
+[dev-dependencies]
+tempfile = "3.10"

crates/pet-homebrew/src/environment_locations.rs

@@ -52,45 +52,31 @@ pub fn get_homebrew_prefix_bin(env_vars: &EnvVariables) -> Vec<PathBuf> {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use std::{
-        fs,
-        time::{SystemTime, UNIX_EPOCH},
-    };
-
-    fn create_unique_prefix(name: &str) -> PathBuf {
-        let unique = SystemTime::now()
-            .duration_since(UNIX_EPOCH)
-            .unwrap()
-            .as_nanos();
-        std::env::temp_dir().join(format!(
-            "pet-homebrew-{name}-{}-{unique}",
-            std::process::id()
-        ))
-    }
+    use std::fs;
+    use tempfile::tempdir;
 
     #[test]
     fn homebrew_prefix_bin_uses_existing_homebrew_prefix_env_var() {
-        let homebrew_prefix = create_unique_prefix("prefix");
-        let homebrew_bin = homebrew_prefix.join("bin");
+        let homebrew_prefix = tempdir().unwrap();
+        let homebrew_bin = homebrew_prefix.path().join("bin");
         fs::create_dir_all(&homebrew_bin).unwrap();
         let env_vars = EnvVariables {
             home: None,
             root: None,
             path: None,
-            homebrew_prefix: Some(homebrew_prefix.to_string_lossy().to_string()),
+            homebrew_prefix: Some(homebrew_prefix.path().to_string_lossy().to_string()),
             known_global_search_locations: vec![],
         };
 
         let prefix_bins = get_homebrew_prefix_bin(&env_vars);
 
         assert!(prefix_bins.contains(&homebrew_bin));
-
-        fs::remove_dir_all(homebrew_prefix).unwrap();
     }
 
     #[test]
     fn homebrew_prefix_bin_ignores_missing_homebrew_prefix_env_var() {
-        let missing_homebrew_prefix = create_unique_prefix("missing-prefix");
+        let homebrew_prefix_parent = tempdir().unwrap();
+        let missing_homebrew_prefix = homebrew_prefix_parent.path().join("missing-prefix");
         let env_vars = EnvVariables {
             home: None,
             root: None,

crates/pet-homebrew/src/lib.rs

@@ -174,7 +174,7 @@ impl Locator for Homebrew {
 #[cfg(all(test, unix))]
 mod tests {
     use super::*;
-    use std::time::{SystemTime, UNIX_EPOCH};
+    use tempfile::tempdir;
 
     struct TestEnvironment {
         homebrew_prefix: Option<String>,
@@ -202,19 +202,6 @@ mod tests {
         }
     }
 
-    fn create_test_dir(name: &str) -> PathBuf {
-        let unique = SystemTime::now()
-            .duration_since(UNIX_EPOCH)
-            .unwrap()
-            .as_nanos();
-        let directory = std::env::temp_dir().join(format!(
-            "pet-homebrew-{name}-{}-{unique}",
-            std::process::id()
-        ));
-        fs::create_dir_all(&directory).unwrap();
-        directory
-    }
-
     #[test]
     fn homebrew_locator_reports_kind_and_supported_category() {
         let locator = Homebrew::from(&TestEnvironment {
@@ -273,24 +260,25 @@ mod tests {
             homebrew_prefix: None,
         });
 
-        let venv_root = create_test_dir("venv-reject");
-        let venv_bin = venv_root.join("bin");
+        let venv_root = tempdir().unwrap();
+        let venv_bin = venv_root.path().join("bin");
         fs::create_dir_all(&venv_bin).unwrap();
         fs::write(venv_bin.join("activate"), b"").unwrap();
         let venv_executable = venv_bin.join("python3.12");
         fs::write(&venv_executable, b"").unwrap();
-        let venv = PythonEnv::new(venv_executable, Some(venv_root.clone()), None);
+        let venv = PythonEnv::new(venv_executable, Some(venv_root.path().to_path_buf()), None);
         assert!(locator.try_from(&venv).is_none());
 
-        let conda_root = create_test_dir("conda-reject");
-        fs::create_dir_all(conda_root.join("conda-meta")).unwrap();
-        let conda_executable = conda_root.join("bin").join("python3.12");
+        let conda_root = tempdir().unwrap();
+        fs::create_dir_all(conda_root.path().join("conda-meta")).unwrap();
+        let conda_executable = conda_root.path().join("bin").join("python3.12");
         fs::create_dir_all(conda_executable.parent().unwrap()).unwrap();
         fs::write(&conda_executable, b"").unwrap();
-        let conda = PythonEnv::new(conda_executable, Some(conda_root.clone()), None);
+        let conda = PythonEnv::new(
+            conda_executable,
+            Some(conda_root.path().to_path_buf()),
+            None,
+        );
         assert!(locator.try_from(&conda).is_none());
-
-        fs::remove_dir_all(venv_root).unwrap();
-        fs::remove_dir_all(conda_root).unwrap();
     }
 }