Skip to content

fix: canonicalize prefix paths before comparison to handle symlinked venvs (Fixes #358) #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 5 commits into from
Feb 25, 2026
+129 −6
Merged

fix: canonicalize prefix paths before comparison to handle symlinked venvs (Fixes #358) #359

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2229bd1
fix: canonicalize prefix paths before comparison to handle symlinked …
karthiknadig Feb 25, 2026
5beccc3
fix: add configure logging and move glob expansion outside write lock
karthiknadig Feb 25, 2026
46bc316
Revert "fix: add configure logging and move glob expansion outside wr…
karthiknadig Feb 25, 2026
42df4c5
test: add test coverage for symlinked prefix comparison
karthiknadig Feb 25, 2026
232fa5e
fix: return inaccuracy info from comparison function, improve test as…
karthiknadig Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions crates/pet-telemetry/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,21 @@ pub fn report_inaccuracies_identified_after_resolving(
executable_not_in_symlinks = false;
}

let mut invalid_prefix = env.prefix.clone().unwrap_or_default() != resolved.prefix.clone()?;
if env.prefix.clone().is_none() {
invalid_prefix = false;
}
let invalid_prefix = if let Some(ref env_prefix) = env.prefix {
let resolved_prefix = resolved.prefix.clone()?;
// Canonicalize both paths to handle symlinks — a venv prefix like
// /usr/local/venvs/myvenv may be a symlink to /usr/local/venvs/versioned/myvenv-1.0.51,
// and sys.prefix returns the resolved target. Without this, the comparison
// produces a false positive "Prefix is incorrect" warning. (See #358)
// Wrap in norm_case to handle Windows UNC prefix (`\\?\`) from canonicalize.
let env_canonical =
norm_case(std::fs::canonicalize(env_prefix).unwrap_or(env_prefix.clone()));
let resolved_canonical =
norm_case(std::fs::canonicalize(&resolved_prefix).unwrap_or(resolved_prefix));
env_canonical != resolved_canonical
} else {
false
};

let mut invalid_arch = env.arch.clone() != resolved.arch.clone();
if env.arch.clone().is_none() {
Expand Down
Loading