Skip to content

fix(pet-conda): shorten test fixture path for Windows compatibility#384

Merged
karthiknadig merged 1 commit intomainfrom
fix/issue-171-shorten-conda-test-paths
Apr 3, 2026
Merged

fix(pet-conda): shorten test fixture path for Windows compatibility#384
karthiknadig merged 1 commit intomainfrom
fix/issue-171-shorten-conda-test-paths

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

Rename the long conda test fixture directory conda_env_without_manager_but_found_in_historyconda_hist so Windows GitHub Actions checkouts stay under the 260-character path limit.

  • Renamed fixture directory and all contained files (26 files)
  • Updated path references in lib_test.rs
  • Updated stale hardcoded paths in the committed history file
  • Passes cargo fmt --all --check and cargo clippy --all -- -D warnings

Fixes #171

@karthiknadig karthiknadig requested a review from Copilot April 3, 2026 01:00
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 65.6%
Base Branch Coverage 65.6%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Performance Report (Linux) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 76ms 377ms 86ms -10ms -10.0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 61.75%
Base Branch Coverage 61.75%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Performance Report (Windows) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 12ms 14ms 9ms 3ms 33.3%
Full Refresh 179ms 379ms 166ms 13ms 7.8%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames a deeply nested conda test fixture directory in pet-conda to reduce checkout path lengths, preventing Windows path-length failures in GitHub Actions while preserving history-based manager detection coverage.

Changes:

  • Renamed the conda history-based fixture root directory to conda_hist to shorten paths.
  • Updated lib_test.rs to reference the new fixture location.
  • Updated fixture history content to remove stale hardcoded references to the old path.

Reviewed changes

Copilot reviewed 2 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/pet-conda/tests/lib_test.rs Updates test fixture path references to use conda_hist.
crates/pet-conda/tests/unix/conda_hist/env_python_3/bin/conda Renamed fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/env_python_3/bin/python Renamed fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/env_python_3/bin/python3 Renamed fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/env_python_3/bin/python3.1 Renamed fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/env_python_3/bin/python3.12 Renamed fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/history Updates committed history content to use the new fixture directory name.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/history_template History template used by test to write a runtime history with substituted conda install path.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/pygments-2.17.2-pyhd8ed1ab_0.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/python_abi-3.12-4_cp312.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/python-3.12.2-hdf0ec26_0_cpython.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/env_python_3/conda-meta/python-dateutil-2.8.2-pyhd8ed1ab_0.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/bin/conda Renamed conda-install fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/bin/python Renamed conda-install fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/bin/python3 Renamed conda-install fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/bin/python3.1 Renamed conda-install fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/bin/python3.10 Renamed conda-install fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/condabin/conda Renamed condabin fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/envs/.conda_envs_dir_test Renamed marker fixture file under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/conda-23.1.0-py310hca03da5_0.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/conda-build-3.23.3-py310hca03da5_0.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/history Renamed conda-meta history fixture under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/pytest-7.1.2-py310hca03da5_0.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/python-3.10.9-hc0d8a6c_1.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/python-dateutil-2.8.2-pyhd3eb1b0_0.json Renamed conda-meta fixture JSON under shorter path root.
crates/pet-conda/tests/unix/conda_hist/some_other_location/conda_install/conda-meta/python-fastjsonschema-2.16.2-py310hca03da5_0.json Renamed conda-meta fixture JSON under shorter path root.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 81ms 716ms 102ms -21ms
Full Refresh 151ms 35710ms 212ms -61ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig merged commit a99cf64 into main Apr 3, 2026
52 of 55 checks passed
@karthiknadig karthiknadig deleted the fix/issue-171-shorten-conda-test-paths branch April 3, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pet crate can't be fetched by cargo in GitHub Actions machine with Windows

3 participants