fix: use atomic counter in pet-pipenv test temp dirs to prevent parallel collisions#408
Merged
karthiknadig merged 1 commit intomainfrom Apr 6, 2026
Merged
fix: use atomic counter in pet-pipenv test temp dirs to prevent parallel collisions#408karthiknadig merged 1 commit intomainfrom
karthiknadig merged 1 commit intomainfrom
Conversation
Test Coverage Report (Linux)
Coverage unchanged. |
Performance Report (Linux) ➖
Legend
|
Performance Report (macOS)
Legend
|
Performance Report (Windows) ➖
Legend
|
Test Coverage Report (Windows)
Coverage decreased. Please add tests for new code. |
rzhao271
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unique_temp_dir()helper in pet-pipenv tests usedSystemTime::now().as_nanos()to generate temp directory names. On Windows,SystemTimehas ~15.6ms resolution, so parallel test threads can get the same value — causing one test's cleanup (remove_dir_all) to destroy another test's files mid-execution.Fix: Replace the nanos-based name with
process_id + AtomicU64 counter, which is guaranteed unique across parallel test threads within the same test binary.This was observed as a flaky
detect_pipenv_centralized_env_without_project_file_via_naming_patternfailure on Windows CI (e.g., PR #407 CI run).