Skip to content

fix: use atomic counter in pet-pipenv test temp dirs to prevent parallel collisions #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 1 commit into from
Apr 6, 2026
Merged

fix: use atomic counter in pet-pipenv test temp dirs to prevent parallel collisions #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/pet-pipenv/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,15 +495,15 @@ impl Locator for PipEnv {
#[cfg(test)]
mod tests {
use super::*;
use std::time::{SystemTime, UNIX_EPOCH};
use std::sync::atomic::{AtomicU64, Ordering};

static TEST_DIR_COUNTER: AtomicU64 = AtomicU64::new(0);

fn unique_temp_dir() -> PathBuf {
let mut dir = std::env::temp_dir();
let nanos = SystemTime::now()
.duration_since(UNIX_EPOCH)
.unwrap()
.as_nanos();
dir.push(format!("pet_pipenv_test_{}", nanos));
let id = std::process::id();
let counter = TEST_DIR_COUNTER.fetch_add(1, Ordering::Relaxed);
dir.push(format!("pet_pipenv_test_{}_{}", id, counter));
dir
}

Expand Down
Loading