Conversation
Performance Report (Linux) ✅
Legend
|
Performance Report (macOS)
Legend
|
Test Coverage Report (Linux)
Coverage increased! Great work! |
Test Coverage Report (Windows)
Coverage increased! Great work! |
Performance Report (Windows) ➖
Legend
|
There was a problem hiding this comment.
Pull request overview
Tightens Poetry cache environment detection in pet-poetry by replacing substring-based path checks with ordered path-component matching, addressing false positives described in #398 while keeping support for common Linux/macOS and Windows cache layouts.
Changes:
- Replaced raw substring checks (
.contains("pypoetry"),.contains("virtualenvs")) with ordered path-component detection. - Added targeted unit tests covering exact components, ordering, case-insensitivity, substring false positives, and invalid Poetry env names.
Show a summary per file
| File | Description |
|---|---|
crates/pet-poetry/src/lib.rs |
Implements component-based cache path matching and adds unit tests to prevent regressions and false positives. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
There was a problem hiding this comment.
Pull request overview
This PR tightens Poetry cache-environment detection in pet-poetry by switching from raw substring checks to ordered path-component matching, reducing false positives for unusual directory names while preserving support for common Linux/macOS and Windows cache layouts.
Changes:
- Replace substring-based cache path detection with ordered path-component matching (
pypoetry→virtualenvs). - Add unit tests covering exact component matching, ordering, mixed case, and substring false positives.
- Update comments to reflect the Poetry env naming pattern that includes a Python version suffix.
Show a summary per file
| File | Description |
|---|---|
| crates/pet-poetry/src/lib.rs | Implements component-based Poetry cache path detection and adds tests for the new behavior. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
There was a problem hiding this comment.
Pull request overview
This PR hardens Poetry cache environment detection in pet-poetry by switching from substring-based path matching to ordered path-component matching, reducing false positives while keeping support for common Linux/macOS and Windows cache layouts.
Changes:
- Replace
Pathsubstring checks with an ordered component scan (pypoetry→virtualenvs) via a new helper. - Update inline documentation around Poetry cache env naming to reflect the expected
-py<major>.<minor>suffix. - Add unit tests covering exact component matching, ordering, mixed case, substring false positives, and invalid env names.
Show a summary per file
| File | Description |
|---|---|
| crates/pet-poetry/src/lib.rs | Tightens Poetry cache path detection logic and adds focused regression tests to prevent substring false positives. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
Summary:
pypoetry/Cache/virtualenvslayout.Validation:
Fixes #398