Skip to content

test: add global virtualenvs coverage#423

Merged
karthiknadig merged 1 commit intomainfrom
test/issue-389-global-virtualenvs
Apr 15, 2026
Merged

test: add global virtualenvs coverage#423
karthiknadig merged 1 commit intomainfrom
test/issue-389-global-virtualenvs

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

Summary:

  • Add coverage for XDG data virtualenv children and default home .virtualenvs children in pet-global-virtualenvs.
  • Keep the assertion on helper ordering/dedup behavior by using the function output directly.
  • Covers a small utility-crate slice from the Coverage: ranked plan to move workspace coverage toward 90% #389 coverage plan.

Validation:

  • cargo test -p pet-global-virtualenvs
  • cargo fmt --all
  • cargo clippy --all -- -D warnings

Refs #389

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 73.7%
Base Branch Coverage 73.6%
Delta .1% ✅

Coverage increased! Great work!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Performance Report (Linux) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 83ms 184ms 96ms -13ms -10.0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 57ms 548ms 58ms -1ms
Full Refresh 117ms 27496ms 99ms 18ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 69.9%
Base Branch Coverage 69.86%
Delta 0.04% ✅

Coverage increased! Great work!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

Performance Report (Windows) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 10ms 15ms 8ms 2ms 25%
Full Refresh 175ms 395ms 128ms 47ms 36.7%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional unit test coverage to the pet-global-virtualenvs utility crate to ensure global virtualenv discovery includes both XDG data locations (pipenv-style) and the default home .virtualenvs location.

Changes:

  • Add a unit test verifying that virtualenv children under $XDG_DATA_HOME/virtualenvs and ~/.virtualenvs are both discovered.
  • Assert deterministic ordering/dedup behavior by comparing directly against the function output (which sorts/dedups internally).
Show a summary per file
File Description
crates/pet-global-virtualenvs/src/lib.rs Adds a new unit test covering XDG + default home virtualenv child discovery paths.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@karthiknadig karthiknadig marked this pull request as ready for review April 13, 2026 02:47
@karthiknadig karthiknadig enabled auto-merge (squash) April 13, 2026 02:48
@karthiknadig karthiknadig merged commit 07f390c into main Apr 15, 2026
34 checks passed
@karthiknadig karthiknadig deleted the test/issue-389-global-virtualenvs branch April 15, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants