Skip to content

Add TSNE param max_iter and deprecate n_iter in scikit-learn #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debonte merged 2 commits into from
Mar 14, 2025
Merged

Add TSNE param max_iter and deprecate n_iter in scikit-learn #354

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d29f3d1
Add TSNE param `max_iter` and deprecate `n_iter` in scikit-learn
notdaniel Mar 13, 2025
0f5c711
Add missing comma
debonte Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions stubs/sklearn/manifold/_t_sne.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
) -> float: ...

class TSNE(BaseEstimator):
n_iter_: int = ...
max_iter: None | int = ...
n_iter_: str | int = ...
learning_rate_: float = ...
feature_names_in_: ndarray = ...
n_features_in_: int = ...
Expand All @@ -62,8 +63,8 @@
perplexity: Float = 30.0,
early_exaggeration: Float = 12.0,
learning_rate: float | Literal["auto"] = "auto",
n_iter: Int = 1000,
max_iter: None | Int = None
n_iter_without_progress: Int = 300,

Check failure on line 67 in stubs/sklearn/manifold/_t_sne.pyi

View workflow job for this annotation

GitHub Actions / hygiene

Ruff 

stubs/sklearn/manifold/_t_sne.pyi:67:9: SyntaxError: Expected ',', found name
min_grad_norm: Float = 1e-7,
metric: str | Callable = "euclidean",
metric_params: None | dict = None,
Expand All @@ -74,6 +75,7 @@
angle: Float = 0.5,
n_jobs: None | Int = None,
square_distances: str | bool = "deprecated",
n_iter: str | Int = "deprecated",
) -> None: ...
def fit_transform(self, X: MatrixLike, y: None | ndarray = None) -> ndarray: ...
def fit(self, X: MatrixLike, y=None) -> ndarray: ...
Loading