feat(config): add explicit validation for required configuration fields#2078
Open
Sourish-07 wants to merge 5 commits into
Open
feat(config): add explicit validation for required configuration fields#2078Sourish-07 wants to merge 5 commits into
Sourish-07 wants to merge 5 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
Hi, @Sourish-07 , Thanks for the contribution! The CI checks are currently failing due to code formatting issues. |
76a14bc to
3dc0db7
Compare
Author
|
Hi, I’ve rebased the branch onto the latest upstream main, cleaned up the formatting issues, and updated the validation logic to respect skip_register. The changes are now pushed to the PR. Please let me know if there are any other changes required. |
3dc0db7 to
c43be31
Compare
Author
|
Hi @SunsetWolf, CI is passing and the requested changes are in. Could you take a quick look and merge if it looks good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR adds explicit validation to the
Configclass to surface missing required configuration fields early, with clear error messages.Why
Currently, missing core fields such as
provider_uriorregioncan lead to unclear runtime errors later in the execution flow. This change fails fast and makes misconfiguration easier to diagnose.What’s included
Config.validate()method that checks required fieldsprovider_uriNotes
Some tests depend on optional development packages (e.g. tqdm), so local test collection may fail on a minimal setup. CI should be used to verify test results.