fix issue with packager

Author: geof90

CodePush.m

@@ -18,13 +18,13 @@ @implementation CodePush {
 static BOOL testConfigurationFlag = NO;
 
 // These constants represent valid deployment statuses
-static NSString *const DeploymentSucceeded = @"DeploymentSucceeded";
 static NSString *const DeploymentFailed = @"DeploymentFailed";
+static NSString *const DeploymentSucceeded = @"DeploymentSucceeded";
 
 // These keys represent the names we use to store data in NSUserDefaults
 static NSString *const FailedUpdatesKey = @"CODE_PUSH_FAILED_UPDATES";
-static NSString *const PendingUpdateKey = @"CODE_PUSH_PENDING_UPDATE";
 static NSString *const LastDeploymentReportKey = @"CODE_PUSH_LAST_DEPLOYMENT_REPORT";
+static NSString *const PendingUpdateKey = @"CODE_PUSH_PENDING_UPDATE";
 
 // These keys are already "namespaced" by the PendingUpdateKey, so
 // their values don't need to be obfuscated to prevent collision with app data
@@ -552,29 +552,22 @@ - (void)savePendingUpdate:(NSString *)packageHash
     } else if (_isFirstRunAfterUpdate) {
         // Check if the current CodePush package has been reported
         NSError *error;
-        NSDictionary* currentPackage = [CodePushPackage getCurrentPackage:&error];
-        if (currentPackage) {
-            NSString* currentPackageIdentifier = [self getPackageStatusReportIdentifier:currentPackage];
+        NSDictionary *currentPackage = [CodePushPackage getCurrentPackage:&error];
+        if (!error && currentPackage) {
+            NSString *currentPackageIdentifier = [self getPackageStatusReportIdentifier:currentPackage];
             if (currentPackageIdentifier && [self isDeploymentStatusNotYetReported:currentPackageIdentifier]) {
                 [self recordDeploymentStatusReported:currentPackageIdentifier];
                 resolve(@{ @"package": currentPackage, @"status": DeploymentSucceeded });
                 return;
             }
         }
-    } else {
-        if (isRunningBinaryVersion) {
-            // Check if the current appVersion has been reported. Use date as the binary identifier to
-            // handle binary releases that do not modify the appVersion.
-            NSURL *binaryJsBundleUrl = [CodePush bundleURL];
-            NSDictionary *binaryFileAttributes = [[NSFileManager defaultManager] attributesOfItemAtPath:[binaryJsBundleUrl path] error:nil];
-            NSTimeInterval binaryDate = [[binaryFileAttributes objectForKey:NSFileModificationDate] timeIntervalSince1970];
-            NSString* binaryIdentifier = [NSString stringWithFormat:@"%f", binaryDate];
-            
-            if ([self isDeploymentStatusNotYetReported:binaryIdentifier]) {
-                [self recordDeploymentStatusReported:binaryIdentifier];
-                resolve(@{ @"appVersion": [[CodePushConfig current] appVersion] });
-                return;
-            }
+    } else if (isRunningBinaryVersion || [_bridge.bundleURL.scheme hasPrefix:@"http"]) {
+        // Check if the current appVersion has been reported.
+        NSString *appVersion = [[CodePushConfig current] appVersion];
+        if ([self isDeploymentStatusNotYetReported:appVersion]) {
+            [self recordDeploymentStatusReported:appVersion];
+            resolve(@{ @"appVersion": appVersion });
+            return;
         }
     }
 

CodePushConfig.m

@@ -33,8 +33,8 @@ - (instancetype)init
     NSString *deploymentKey = [infoDictionary objectForKey:@"CodePushDeploymentKey"];
     NSString *serverURL = [infoDictionary objectForKey:@"CodePushServerURL"];
 
-    NSUserDefaults* userDefaults = [NSUserDefaults standardUserDefaults];
-    NSString* clientUniqueId = [userDefaults stringForKey:ClientUniqueIDConfigKey];
+    NSUserDefaults *userDefaults = [NSUserDefaults standardUserDefaults];
+    NSString *clientUniqueId = [userDefaults stringForKey:ClientUniqueIDConfigKey];
     if (clientUniqueId == nil) {
         clientUniqueId = [[[UIDevice currentDevice] identifierForVendor] UUIDString];
         [userDefaults setObject:clientUniqueId forKey:ClientUniqueIDConfigKey];

android/app/src/main/java/com/microsoft/codepush/react/CodePush.java

@@ -491,17 +491,15 @@ public void getNewStatusReport(Promise promise) {
                         return;
                     }
                 }
-            } else {
-                if (isRunningBinaryVersion) {
-                    // Check if the current appVersion has been reported.
-                    String binaryIdentifier = "" + getBinaryResourcesModifiedTime();
-                    if (isDeploymentStatusNotYetReported(binaryIdentifier)) {
-                        recordDeploymentStatusReported(binaryIdentifier);
-                        WritableNativeMap reportMap = new WritableNativeMap();
-                        reportMap.putString("appVersion", appVersion);
-                        promise.resolve(reportMap);
-                        return;
-                    }
+            } else if (isRunningBinaryVersion) {
+                // Check if the current appVersion has been reported.
+                String binaryIdentifier = "" + getBinaryResourcesModifiedTime();
+                if (isDeploymentStatusNotYetReported(binaryIdentifier)) {
+                    recordDeploymentStatusReported(binaryIdentifier);
+                    WritableNativeMap reportMap = new WritableNativeMap();
+                    reportMap.putString("appVersion", appVersion);
+                    promise.resolve(reportMap);
+                    return;
                 }
             }
 

request-fetch-adapter.js

@@ -1,24 +1,24 @@
 module.exports = {
-  async request(verb, url, body, callback) {
-    if (typeof body === "function") {
-      callback = body;
-      body = null;
+  async request(verb, url, requestBody, callback) {
+    if (typeof requestBody === "function") {
+      callback = requestBody;
+      requestBody = null;
     }
 
     var headers = {
       "Accept": "application/json",
       "Content-Type": "application/json"
     };
 
-    if (body && typeof body === "object") {
-      body = JSON.stringify(body);
+    if (requestBody && typeof requestBody === "object") {
+      requestBody = JSON.stringify(requestBody);
     }
 
     try {
       const response = await fetch(url, {
         method: getHttpMethodName(verb),
         headers: headers,
-        body: body
+        body: requestBody
       });
 
       const statusCode = response.status;