0.29 compat + refactoring android (#398)

0.29 compat

Author: geof90

Examples/CodePushDemoApp/android/app/src/main/java/com/microsoft/codepushdemoapp/MainActivity.java

@@ -12,7 +12,7 @@ public class MainActivity extends ReactActivity {
 
     @Override
     protected String getJSBundleFile() {
-        return CodePush.getBundleUrl("index.android.bundle");
+        return CodePush.getJSBundleFile();
     }
 
     /**

README.md

@@ -10,7 +10,7 @@ android {
         versionCode 1
         versionName "1.0"
     }
-    
+
     buildTypes {
         release {
             minifyEnabled false
@@ -22,5 +22,5 @@ android {
 dependencies {
     compile fileTree(dir: "libs", include: ["*.jar"])
     compile "com.android.support:appcompat-v7:23.0.1"
-    compile "com.facebook.react:react-native:0.19.+"
+    compile "com.facebook.react:react-native:+"
 }

android/app/build.gradle

@@ -0,0 +1,28 @@
+package com.microsoft.codepush.react;
+
+public class CodePushConstants {
+    public static final String ASSETS_BUNDLE_PREFIX = "assets://";
+    public static final String BINARY_MODIFIED_TIME_KEY = "binaryModifiedTime";
+    public static final String CODE_PUSH_FOLDER_PREFIX = "CodePush";
+    public static final String CODE_PUSH_HASH_FILE_NAME = "CodePushHash.json";
+    public static final String CODE_PUSH_PREFERENCES = "CodePush";
+    public static final String CURRENT_PACKAGE_KEY = "currentPackage";
+    public static final String DEFAULT_JS_BUNDLE_NAME = "index.android.bundle";
+    public static final String DIFF_MANIFEST_FILE_NAME = "hotcodepush.json";
+    public static final int DOWNLOAD_BUFFER_SIZE = 1024 * 256;
+    public static final String DOWNLOAD_FILE_NAME = "download.zip";
+    public static final String DOWNLOAD_PROGRESS_EVENT_NAME = "CodePushDownloadProgress";
+    public static final String DOWNLOAD_URL_KEY = "downloadUrl";
+    public static final String FAILED_UPDATES_KEY = "CODE_PUSH_FAILED_UPDATES";
+    public static final String PACKAGE_FILE_NAME = "app.json";
+    public static final String PACKAGE_HASH_KEY = "packageHash";
+    public static final String PENDING_UPDATE_HASH_KEY = "hash";
+    public static final String PENDING_UPDATE_IS_LOADING_KEY = "isLoading";
+    public static final String PENDING_UPDATE_KEY = "CODE_PUSH_PENDING_UPDATE";
+    public static final String PREVIOUS_PACKAGE_KEY = "previousPackage";
+    public static final String REACT_NATIVE_LOG_TAG = "ReactNative";
+    public static final String RELATIVE_BUNDLE_PATH_KEY = "bundlePath";
+    public static final String RESOURCES_BUNDLE = "resources.arsc";
+    public static final String STATUS_FILE = "codepush.json";
+    public static final String UNZIPPED_FOLDER_NAME = "unzipped";
+}

android/app/src/main/java/com/microsoft/codepush/react/CodePush.java

@@ -11,30 +11,20 @@
 
 public class CodePushDialog extends ReactContextBaseJavaModule{
 
-    private Activity mainActivity;
-
-    public CodePushDialog(ReactApplicationContext reactContext, Activity mainActivity) {
+    public CodePushDialog(ReactApplicationContext reactContext) {
         super(reactContext);
-        this.mainActivity = mainActivity;
     }
 
     @ReactMethod
     public void showDialog(String title, String message, String button1Text, String button2Text,
                       final Callback successCallback, Callback errorCallback) {
-        AlertDialog.Builder builder = new AlertDialog.Builder(mainActivity);
+        AlertDialog.Builder builder = new AlertDialog.Builder(getCurrentActivity());
 
         builder.setCancelable(false);
 
         DialogInterface.OnClickListener clickListener = new DialogInterface.OnClickListener() {
-            private boolean callbackConsumed = false;
-
             @Override
-            public synchronized void onClick(DialogInterface dialog, int which) {
-                if (callbackConsumed) {
-                    return;
-                }
-
-                callbackConsumed = true;
+            public void onClick(DialogInterface dialog, int which) {
                 dialog.cancel();
                 switch (which) {
                     case DialogInterface.BUTTON_POSITIVE: