Merge pull request #478 from Microsoft/fix-autobind-warning

Don't bind lifecycle hooks if root component instance is not ES6 declared

Author: geof90

CodePush.js

@@ -431,12 +431,18 @@ function codePushify(options = {}) {
 
           let syncStatusCallback;
           if (rootComponentInstance && rootComponentInstance.codePushStatusDidChange) {
-            syncStatusCallback = rootComponentInstance.codePushStatusDidChange.bind(rootComponentInstance);
+            syncStatusCallback = rootComponentInstance.codePushStatusDidChange;
+            if (rootComponentInstance instanceof React.Component) {
+              syncStatusCallback = syncStatusCallback.bind(rootComponentInstance);
+            }
           }
 
           let downloadProgressCallback;
           if (rootComponentInstance && rootComponentInstance.codePushDownloadDidProgress) {
-            downloadProgressCallback = rootComponentInstance.codePushDownloadDidProgress.bind(rootComponentInstance);
+            downloadProgressCallback = rootComponentInstance.codePushDownloadDidProgress;
+            if (rootComponentInstance instanceof React.Component) {
+              downloadProgressCallback = downloadProgressCallback.bind(rootComponentInstance);
+            }
           }
 
           CodePush.sync(options, syncStatusCallback, downloadProgressCallback);

Examples/CodePushDemoApp/demo.js

@@ -19,7 +19,6 @@ class CodePushDemoApp extends Component {
   }
 
   codePushStatusDidChange(syncStatus) {
-    console.log(this.setState);
     switch(syncStatus) {
       case CodePush.SyncStatus.CHECKING_FOR_UPDATE:
         this.setState({ syncMessage: "Checking for update." });