Merge pull request #218 from Microsoft/handle-uncleared-updates-debug

Handle uncleared updates during debug

Author: geof90

CodePush.js

@@ -70,7 +70,9 @@ async function checkForUpdate(deploymentKey = null) {
    *    because we want to avoid having to install diff updates against the binary's
    *    version, which we can't do yet on Android.
    */
-  if (!update || update.updateAppVersion || localPackage && (update.packageHash === localPackage.packageHash) || !localPackage && config.packageHash === update.packageHash) {
+  if (!update || update.updateAppVersion || 
+      localPackage && (update.packageHash === localPackage.packageHash) || 
+      (!localPackage || localPackage._isDebugOnly) && config.packageHash === update.packageHash) {
     if (update && update.updateAppVersion) {
       log("An update is available but it is targeting a newer binary version than you are currently running.");
     }

android/app/src/main/java/com/microsoft/codepush/react/CodePush.java

@@ -423,6 +423,10 @@ protected Void doInBackground(Object... params) {
                         return null;
                     }
 
+                    if (isRunningBinaryVersion) {
+                        currentPackage.putBoolean("_isDebugOnly", true);
+                    }
+
                     Boolean isPendingUpdate = false;
 
                     if (currentPackage.hasKey(codePushPackage.PACKAGE_HASH_KEY)) {

ios/CodePush/CodePush.m

@@ -480,6 +480,13 @@ - (void)savePendingUpdate:(NSString *)packageHash
         return;
     }
 
+    if (isRunningBinaryVersion) {
+        // This only matters in Debug builds. Since we do not clear "outdated" updates,
+        // we need to indicate to the JS side that somehow we have a current update on
+        // disk that is not actually running.
+        [package setObject:@(YES) forKey:@"_isDebugOnly"];
+    }
+    
     // Add the "isPending" virtual property to the package at this point, so that
     // the script-side doesn't need to immediately call back into native to populate it.
     BOOL isPendingUpdate = [self isPendingUpdate:[package objectForKey:PackageHashKey]];