add defaultForegroundTextColor()

Author: Saadnajmi

packages/react-native/ReactCommon/react/renderer/attributedstring/TextAttributes.cpp

@@ -178,10 +178,7 @@ TextAttributes TextAttributes::defaultTextAttributes() {
   static auto textAttributes = [] {
     auto textAttributes = TextAttributes{};
     // Non-obvious (can be different among platforms) default text attributes.
-    // [macOS textAttributes.foregroundColor = blackColor();
-    // Leave foregroundColor unset so each platform can apply a dynamic default
-    // (e.g. labelColor) that adapts to light/dark mode.
-    // macOS]
+    textAttributes.foregroundColor = defaultForegroundTextColor(); // [macOS]
     textAttributes.backgroundColor = clearColor();
     textAttributes.fontSize = 14.0;
     textAttributes.fontSizeMultiplier = 1.0;

packages/react-native/ReactCommon/react/renderer/graphics/Color.h

@@ -70,6 +70,7 @@ SharedColor colorFromRGBA(uint8_t r, uint8_t g, uint8_t b, uint8_t a);
 SharedColor clearColor();
 SharedColor blackColor();
 SharedColor whiteColor();
+SharedColor defaultForegroundTextColor(); // [macOS]
 
 #ifdef RN_SERIALIZABLE_STATE
 inline folly::dynamic toDynamic(const SharedColor& sharedColor) {

packages/react-native/ReactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/HostPlatformColor.mm

@@ -10,6 +10,7 @@
 #import <Foundation/Foundation.h>
 #import <React/RCTUIKit.h> // [macOS]
 #import <objc/runtime.h>
+#import <react/renderer/graphics/Color.h> // [macOS]
 #import <react/renderer/graphics/RCTPlatformColorUtils.h>
 #import <react/utils/ManagedObjectWrapper.h>
 #import <string>
@@ -342,6 +343,16 @@ int32_t ColorFromUIColor(const std::shared_ptr<void> &uiColor)
   return Color(wrapManagedObject(semanticColor));
 }
 
+// [macOS
+SharedColor defaultForegroundTextColor() {
+  static SharedColor color = [] {
+    std::vector<std::string> items = {"labelColor"};
+    return SharedColor(Color::createSemanticColor(items));
+  }();
+  return color;
+}
+// macOS]
+
 } // namespace facebook::react
 
 NS_ASSUME_NONNULL_END

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.mm

@@ -182,9 +182,6 @@ inline static CGFloat RCTEffectiveFontSizeMultiplierFromTextAttributes(const Tex
 
   if (textAttributes.foregroundColor || !isnan(textAttributes.opacity)) {
     attributes[NSForegroundColorAttributeName] = effectiveForegroundColor;
-  } else {
-    // [macOS] Apply dynamic default (labelColor) so text adapts to dark mode
-    attributes[NSForegroundColorAttributeName] = effectiveForegroundColor;
   }
 
   if (textAttributes.backgroundColor || !isnan(textAttributes.opacity)) {