Skip to content

Commit 25cd393

Browse files
Saadnajmiclaude
andcommitted
ci: use microsoft-setup-toolchain for Hermes build jobs
Replace manual Xcode and Node.js setup in resolve-hermes, build-hermesc, and build-hermes-slice with the shared microsoft-setup-toolchain action for version consistency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 821930a commit 25cd393

1 file changed

Lines changed: 24 additions & 19 deletions

File tree

.github/workflows/microsoft-prebuild-macos-core.yml

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,11 @@ jobs:
1818
filter: blob:none
1919
fetch-depth: 0
2020

21-
- name: Setup Xcode
22-
run: sudo xcode-select --switch /Applications/Xcode_16.2.app
23-
24-
- name: Set up Node.js
25-
uses: actions/setup-node@v4.4.0
21+
- name: Setup toolchain
22+
uses: ./.github/actions/microsoft-setup-toolchain
2623
with:
2724
node-version: '22'
28-
cache: yarn
29-
registry-url: https://registry.npmjs.org
25+
platform: macos
3026

3127
- name: Install npm dependencies
3228
run: yarn install
@@ -100,8 +96,11 @@ jobs:
10096
with:
10197
filter: blob:none
10298

103-
- name: Setup Xcode
104-
run: sudo xcode-select --switch /Applications/Xcode_16.2.app
99+
- name: Setup toolchain
100+
uses: ./.github/actions/microsoft-setup-toolchain
101+
with:
102+
platform: macos
103+
cache-npm-dependencies: ''
105104

106105
- name: Clone Hermes
107106
uses: actions/checkout@v4
@@ -137,21 +136,27 @@ jobs:
137136
fail-fast: false
138137
matrix:
139138
slice: [iphoneos, iphonesimulator, macosx, xros, xrsimulator]
139+
include:
140+
- slice: iphoneos
141+
platform: ios
142+
- slice: iphonesimulator
143+
platform: ios
144+
- slice: macosx
145+
platform: macos
146+
- slice: xros
147+
platform: visionos
148+
- slice: xrsimulator
149+
platform: visionos
140150
steps:
141151
- uses: actions/checkout@v4
142152
with:
143153
filter: blob:none
144154

145-
- name: Setup Xcode
146-
run: sudo xcode-select --switch /Applications/Xcode_16.2.app
147-
148-
- name: Download visionOS SDK
149-
if: ${{ matrix.slice == 'xros' || matrix.slice == 'xrsimulator' }}
150-
run: |
151-
sudo xcodebuild -runFirstLaunch
152-
sudo xcrun simctl list
153-
sudo xcodebuild -downloadPlatform visionOS
154-
sudo xcodebuild -runFirstLaunch
155+
- name: Setup toolchain
156+
uses: ./.github/actions/microsoft-setup-toolchain
157+
with:
158+
platform: ${{ matrix.platform }}
159+
cache-npm-dependencies: ''
155160

156161
- name: Clone Hermes
157162
uses: actions/checkout@v4

0 commit comments

Comments
 (0)