Skip to content

Commit 410c01e

Browse files
Saadnajmiclaude
andcommitted
feat: include macOS slice in Hermes xcframework
Add "macosx" to the create_universal_framework call so the published Hermes xcframework includes a native macOS slice. The macOS framework is already built by build-mac-framework.sh and placed in destroot/Library/Frameworks/macosx/ — it just wasn't included in the xcodebuild -create-xcframework step. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent fd54030 commit 410c01e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function build_framework {
5353
# group the frameworks together to create a universal framework
5454
function build_universal_framework {
5555
if [ ! -d destroot/Library/Frameworks/universal/hermes.xcframework ]; then
56-
create_universal_framework "iphoneos" "iphonesimulator" "catalyst" "xros" "xrsimulator" "appletvos" "appletvsimulator"
56+
create_universal_framework "macosx" "iphoneos" "iphonesimulator" "catalyst" "xros" "xrsimulator" "appletvos" "appletvsimulator"
5757
else
5858
echo "Skipping; Clean \"destroot\" to rebuild".
5959
fi

0 commit comments

Comments
 (0)