fix(fabric): Add back compat layer for validKeysDown and validKeysUp (#2879)

Saadnajmi · web-flow · commit 7284602731dc · 2026-04-03T06:02:18.000-07:00
diff --git a/packages/react-native/Libraries/Components/Pressable/Pressable.js b/packages/react-native/Libraries/Components/Pressable/Pressable.js
@@ -381,7 +381,14 @@ function Pressable({
     // [macOS
     acceptsFirstMouse: acceptsFirstMouse !== false && !disabled,
     enableFocusRing: enableFocusRing !== false && !disabled,
-    keyDownEvents: keyDownEvents ?? [{key: ' '}, {key: 'Enter'}],
+    keyDownEvents:
+      keyDownEvents ??
+      // $FlowFixMe[unclear-type] Legacy props not in type definitions
+      (((props: any).validKeysDown: mixed) == null &&
+      // $FlowFixMe[unclear-type]
+      ((props: any).passthroughAllKeyEvents: mixed) !== true
+        ? [{key: ' '}, {key: 'Enter'}]
+        : undefined),
     mouseDownCanMoveWindow: false,
     // macOS]
   };
diff --git a/packages/react-native/Libraries/Components/TextInput/RCTTextInputViewConfig.js b/packages/react-native/Libraries/Components/TextInput/RCTTextInputViewConfig.js
@@ -52,6 +52,18 @@ const RCTTextInputViewConfig: PartialViewConfigWithoutName = {
         captured: 'onSubmitEditingCapture',
       },
     },
+    topKeyDown: {
+      phasedRegistrationNames: {
+        bubbled: 'onKeyDown',
+        captured: 'onKeyDownCapture',
+      },
+    },
+    topKeyUp: {
+      phasedRegistrationNames: {
+        bubbled: 'onKeyUp',
+        captured: 'onKeyUpCapture',
+      },
+    },
     topTouchCancel: {
       phasedRegistrationNames: {
         bubbled: 'onTouchCancel',
@@ -173,6 +185,8 @@ const RCTTextInputViewConfig: PartialViewConfigWithoutName = {
     clearTextOnSubmit: true,
     grammarCheck: true,
     hideVerticalScrollIndicator: true,
+    keyDownEvents: true,
+    keyUpEvents: true,
     pastedTypes: true,
     submitKeyEvents: true,
     tooltip: true,
@@ -191,6 +205,8 @@ const RCTTextInputViewConfig: PartialViewConfigWithoutName = {
       onAutoCorrectChange: true,
       onSpellCheckChange: true,
       onGrammarCheckChange: true,
+      onKeyDown: true,
+      onKeyUp: true,
       // macOS]
     }),
     disableKeyboardShortcuts: true,
diff --git a/packages/react-native/Libraries/Components/TextInput/TextInput.js b/packages/react-native/Libraries/Components/TextInput/TextInput.js
@@ -60,7 +60,13 @@ import flattenStyle from '../../StyleSheet/flattenStyle';
 import StyleSheet, {type TextStyleProp} from '../../StyleSheet/StyleSheet';
 import Text from '../../Text/Text';
 import TextAncestorContext from '../../Text/TextAncestorContext';
+// [macOS
+import processLegacyKeyProps, {
+  hasLegacyKeyProps,
+  stripLegacyKeyProps,
+} from '../../Utilities/normalizeLegacyHandledKeyEvents';
 import Platform from '../../Utilities/Platform';
+// macOS]
 import useMergeRefs from '../../Utilities/useMergeRefs';
 import TextInputState from './TextInputState';
 import invariant from 'invariant';
@@ -386,6 +392,11 @@ function useTextInputStateSynchronization({
  *
  */
 function InternalTextInput(props: TextInputProps): React.Node {
+  // [macOS
+  const legacyKeyOverrides = hasLegacyKeyProps(props)
+    ? processLegacyKeyProps(props)
+    : null;
+  // macOS]
   const {
     'aria-busy': ariaBusy,
     'aria-checked': ariaChecked,
@@ -400,7 +411,9 @@ function InternalTextInput(props: TextInputProps): React.Node {
     selectionHandleColor,
     cursorColor,
     ...otherProps
-  } = props;
+    // $FlowFixMe[unclear-type]
+  } = ({...props, ...legacyKeyOverrides}: any); // [macOS]
+  stripLegacyKeyProps(otherProps); // [macOS]
 
   const inputRef = useRef<null | TextInputInstance>(null);
 
@@ -581,10 +594,15 @@ function InternalTextInput(props: TextInputProps): React.Node {
   };
 
   // [macOS
+  const _keyDownEvents =
+    legacyKeyOverrides?.keyDownEvents ?? props.keyDownEvents;
+  const _keyUpEvents = legacyKeyOverrides?.keyUpEvents ?? props.keyUpEvents;
+  const _origOnKeyDown = legacyKeyOverrides?.onKeyDown ?? props.onKeyDown;
+  const _origOnKeyUp = legacyKeyOverrides?.onKeyUp ?? props.onKeyUp;
+
   const _onKeyDown = (event: KeyEvent) => {
-    const keyDownEvents = props.keyDownEvents;
-    if (keyDownEvents != null && !event.isPropagationStopped()) {
-      const isHandled = keyDownEvents.some(
+    if (_keyDownEvents != null && !event.isPropagationStopped()) {
+      const isHandled = _keyDownEvents.some(
         ({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
           return (
             event.nativeEvent.key === key &&
@@ -599,13 +617,12 @@ function InternalTextInput(props: TextInputProps): React.Node {
         event.stopPropagation();
       }
     }
-    props.onKeyDown?.(event);
+    _origOnKeyDown?.(event);
   };
 
   const _onKeyUp = (event: KeyEvent) => {
-    const keyUpEvents = props.keyUpEvents;
-    if (keyUpEvents != null && !event.isPropagationStopped()) {
-      const isHandled = keyUpEvents.some(
+    if (_keyUpEvents != null && !event.isPropagationStopped()) {
+      const isHandled = _keyUpEvents.some(
         ({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
           return (
             event.nativeEvent.key === key &&
@@ -620,7 +637,7 @@ function InternalTextInput(props: TextInputProps): React.Node {
         event.stopPropagation();
       }
     }
-    props.onKeyUp?.(event);
+    _origOnKeyUp?.(event);
   };
   // macOS]
 
diff --git a/packages/react-native/Libraries/Components/View/View.js b/packages/react-native/Libraries/Components/View/View.js
@@ -13,6 +13,12 @@ import type {ViewProps} from './ViewPropTypes';
 
 import * as ReactNativeFeatureFlags from '../../../src/private/featureflags/ReactNativeFeatureFlags';
 import TextAncestorContext from '../../Text/TextAncestorContext';
+// [macOS
+import processLegacyKeyProps, {
+  hasLegacyKeyProps,
+  stripLegacyKeyProps,
+} from '../../Utilities/normalizeLegacyHandledKeyEvents';
+// macOS]
 import ViewNativeComponent from './ViewNativeComponent';
 import * as React from 'react';
 import {use} from 'react';
@@ -30,13 +36,24 @@ export default component View(
 ) {
   const hasTextAncestor = use(TextAncestorContext);
 
+  // [macOS
+  const legacyKeyOverrides = hasLegacyKeyProps(props)
+    ? processLegacyKeyProps(props)
+    : null;
+  // macOS]
+
   let actualView;
 
   // [macOS
+  const _keyDownEvents =
+    legacyKeyOverrides?.keyDownEvents ?? props.keyDownEvents;
+  const _keyUpEvents = legacyKeyOverrides?.keyUpEvents ?? props.keyUpEvents;
+  const _origOnKeyDown = legacyKeyOverrides?.onKeyDown ?? props.onKeyDown;
+  const _origOnKeyUp = legacyKeyOverrides?.onKeyUp ?? props.onKeyUp;
+
   const _onKeyDown = (event: KeyEvent) => {
-    const keyDownEvents = props.keyDownEvents;
-    if (keyDownEvents != null && !event.isPropagationStopped()) {
-      const isHandled = keyDownEvents.some(
+    if (_keyDownEvents != null && !event.isPropagationStopped()) {
+      const isHandled = _keyDownEvents.some(
         ({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
           return (
             event.nativeEvent.key === key &&
@@ -51,13 +68,12 @@ export default component View(
         event.stopPropagation();
       }
     }
-    props.onKeyDown?.(event);
+    _origOnKeyDown?.(event);
   };
 
   const _onKeyUp = (event: KeyEvent) => {
-    const keyUpEvents = props.keyUpEvents;
-    if (keyUpEvents != null && !event.isPropagationStopped()) {
-      const isHandled = keyUpEvents.some(
+    if (_keyUpEvents != null && !event.isPropagationStopped()) {
+      const isHandled = _keyUpEvents.some(
         ({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
           return (
             event.nativeEvent.key === key &&
@@ -72,7 +88,7 @@ export default component View(
         event.stopPropagation();
       }
     }
-    props.onKeyUp?.(event);
+    _origOnKeyUp?.(event);
   };
   // macOS]
 
@@ -96,10 +112,12 @@ export default component View(
       id,
       tabIndex,
       ...otherProps
-    } = props;
+      // $FlowFixMe[unclear-type]
+    } = ({...props, ...legacyKeyOverrides}: any); // [macOS]
 
     // Since we destructured props, we can now treat it as mutable
     const processedProps = otherProps as {...ViewProps};
+    stripLegacyKeyProps(processedProps); // [macOS]
 
     const parsedAriaLabelledBy = ariaLabelledBy?.split(/\s*,\s*/g);
     if (parsedAriaLabelledBy !== undefined) {
@@ -195,7 +213,9 @@ export default component View(
       nativeID,
       tabIndex,
       ...otherProps
-    } = props;
+      // $FlowFixMe[unclear-type]
+    } = ({...props, ...legacyKeyOverrides}: any); // [macOS]
+    stripLegacyKeyProps(otherProps); // [macOS]
     const _accessibilityLabelledBy =
       ariaLabelledBy?.split(/\s*,\s*/g) ?? accessibilityLabelledBy;
 
diff --git a/packages/react-native/Libraries/Utilities/normalizeLegacyHandledKeyEvents.js b/packages/react-native/Libraries/Utilities/normalizeLegacyHandledKeyEvents.js
@@ -0,0 +1,164 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @format
+ */
+
+// [macOS]
+// Legacy validKeysDown/validKeysUp/passthroughAllKeyEvents compat layer.
+// When removing legacy support, delete this file and its call sites.
+
+import type {HandledKeyEvent, KeyEvent} from '../Types/CoreEventTypes';
+
+type LegacyHandledKeyEvent = string | HandledKeyEvent;
+
+function expandKey(entry: LegacyHandledKeyEvent): Array<HandledKeyEvent> {
+  if (typeof entry !== 'string') {
+    return [entry];
+  }
+  const out: Array<HandledKeyEvent> = [];
+  const bools: Array<boolean> = [false, true];
+  for (const metaKey of bools) {
+    for (const ctrlKey of bools) {
+      for (const altKey of bools) {
+        for (const shiftKey of bools) {
+          out.push({altKey, ctrlKey, key: entry, metaKey, shiftKey});
+        }
+      }
+    }
+  }
+  return out;
+}
+
+function normalize(
+  legacy: ?$ReadOnlyArray<LegacyHandledKeyEvent>,
+): void | Array<HandledKeyEvent> {
+  if (legacy == null) {
+    return undefined;
+  }
+  const result: Array<HandledKeyEvent> = [];
+  for (const entry of legacy) {
+    result.push(...expandKey(entry));
+  }
+  return result;
+}
+
+function matchesEvent(
+  events: $ReadOnlyArray<HandledKeyEvent>,
+  event: KeyEvent,
+): boolean {
+  return events.some(
+    ({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) =>
+      event.nativeEvent.key === key &&
+      Boolean(metaKey) === event.nativeEvent.metaKey &&
+      Boolean(ctrlKey) === event.nativeEvent.ctrlKey &&
+      Boolean(altKey) === event.nativeEvent.altKey &&
+      Boolean(shiftKey) === event.nativeEvent.shiftKey,
+  );
+}
+
+export type LegacyKeyResult = {
+  keyDownEvents: void | Array<HandledKeyEvent>,
+  keyUpEvents: void | Array<HandledKeyEvent>,
+  onKeyDown: void | ((event: KeyEvent) => void),
+  onKeyUp: void | ((event: KeyEvent) => void),
+};
+
+/**
+ * Returns true if the props contain legacy key props that need processing.
+ */
+export function hasLegacyKeyProps(props: mixed): boolean {
+  // $FlowFixMe[unclear-type]
+  const p = (props: any);
+  return (
+    p.validKeysDown != null ||
+    p.validKeysUp != null ||
+    p.passthroughAllKeyEvents != null
+  );
+}
+
+/**
+ * Strips legacy props from a props object (mutates).
+ */
+export function stripLegacyKeyProps(props: {+[string]: mixed}): void {
+  // $FlowFixMe[unclear-type]
+  const p = (props: any);
+  delete p.validKeysDown;
+  delete p.validKeysUp;
+  delete p.passthroughAllKeyEvents;
+}
+
+/**
+ * Processes legacy validKeysDown/validKeysUp/passthroughAllKeyEvents props
+ * and returns the equivalent modern keyDownEvents/keyUpEvents and wrapped
+ * onKeyDown/onKeyUp handlers.
+ *
+ * Usage in component:
+ *   if (hasLegacyKeyProps(props)) {
+ *     const legacy = processLegacyKeyProps(props);
+ *     // use legacy.keyDownEvents, legacy.onKeyDown, etc.
+ *   }
+ */
+export default function processLegacyKeyProps(
+  // $FlowFixMe[unclear-type]
+  props: any,
+): LegacyKeyResult {
+  const validKeysDown: ?$ReadOnlyArray<LegacyHandledKeyEvent> =
+    props.validKeysDown;
+  const validKeysUp: ?$ReadOnlyArray<LegacyHandledKeyEvent> = props.validKeysUp;
+  const passthroughAllKeyEvents: ?boolean = props.passthroughAllKeyEvents;
+
+  const hasModernKeyDown = props.keyDownEvents != null;
+  const hasModernKeyUp = props.keyUpEvents != null;
+  const legacyPassthrough =
+    passthroughAllKeyEvents === true && !hasModernKeyDown;
+
+  const gateKeyDown =
+    !hasModernKeyDown && validKeysDown != null && !legacyPassthrough;
+  const gateKeyUp =
+    !hasModernKeyUp && validKeysUp != null && !legacyPassthrough;
+
+  const normalizedDown = props.keyDownEvents ?? normalize(validKeysDown);
+  const normalizedUp = props.keyUpEvents ?? normalize(validKeysUp);
+
+  const keyDownEvents = legacyPassthrough ? undefined : normalizedDown;
+  const keyUpEvents = legacyPassthrough ? undefined : normalizedUp;
+
+  const onKeyDown =
+    props.onKeyDown != null
+      ? (event: KeyEvent) => {
+          let isHandled = false;
+          if (normalizedDown != null && !event.isPropagationStopped()) {
+            isHandled = matchesEvent(normalizedDown, event);
+            if (isHandled && hasModernKeyDown) {
+              event.stopPropagation();
+            }
+          }
+          if (!gateKeyDown || isHandled) {
+            props.onKeyDown?.(event);
+          }
+        }
+      : undefined;
+
+  const onKeyUp =
+    props.onKeyUp != null
+      ? (event: KeyEvent) => {
+          let isHandled = false;
+          if (normalizedUp != null && !event.isPropagationStopped()) {
+            isHandled = matchesEvent(normalizedUp, event);
+            if (isHandled && hasModernKeyUp) {
+              event.stopPropagation();
+            }
+          }
+          if (!gateKeyUp || isHandled) {
+            props.onKeyUp?.(event);
+          }
+        }
+      : undefined;
+
+  return {keyDownEvents, keyUpEvents, onKeyDown, onKeyUp};
+}
diff --git a/packages/rn-tester/js/examples/KeyboardEventsExample/KeyboardEventsExample.js b/packages/rn-tester/js/examples/KeyboardEventsExample/KeyboardEventsExample.js
