Commit 7426ad3
committed
fix: remove duplicate scrollview subspec from React-FabricComponents
The `scrollview` subspec is declared in BOTH React-Fabric.podspec
and React-FabricComponents.podspec with overlapping source_files
(both include `react/renderer/components/scrollview/*.cpp`). This
causes ScrollViewShadowNode.cpp and related sources to be compiled
into both the React-Fabric and React-FabricComponents pod targets.
Consumers that link both libraries (e.g. via `-all_load`) hit
duplicate symbol errors. Consumers that link only React-Fabric
break differently if the duplicate-removal happens to drop the
sources from React-Fabric (which it does on some downstream
generators) -- React-Fabric's `mounting/internal/CullingContext.cpp`
references `ScrollViewShadowNode`, so without those sources in the
same lib, link fails with `Undefined symbols: ScrollViewShadowNode`.
Keep the scrollview subspec only in React-Fabric (where the existing
`react/renderer/components/scrollview/**/*` glob already covers the
files React-FabricComponents was listing).1 parent eb3bccb commit 7426ad3
1 file changed
Lines changed: 0 additions & 9 deletions
Lines changed: 0 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | 104 | | |
114 | 105 | | |
115 | 106 | | |
| |||
0 commit comments