Skip to content

Commit 7426ad3

Browse files
committed
fix: remove duplicate scrollview subspec from React-FabricComponents
The `scrollview` subspec is declared in BOTH React-Fabric.podspec and React-FabricComponents.podspec with overlapping source_files (both include `react/renderer/components/scrollview/*.cpp`). This causes ScrollViewShadowNode.cpp and related sources to be compiled into both the React-Fabric and React-FabricComponents pod targets. Consumers that link both libraries (e.g. via `-all_load`) hit duplicate symbol errors. Consumers that link only React-Fabric break differently if the duplicate-removal happens to drop the sources from React-Fabric (which it does on some downstream generators) -- React-Fabric's `mounting/internal/CullingContext.cpp` references `ScrollViewShadowNode`, so without those sources in the same lib, link fails with `Undefined symbols: ScrollViewShadowNode`. Keep the scrollview subspec only in React-Fabric (where the existing `react/renderer/components/scrollview/**/*` glob already covers the files React-FabricComponents was listing).
1 parent eb3bccb commit 7426ad3

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

packages/react-native/ReactCommon/React-FabricComponents.podspec

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,6 @@ Pod::Spec.new do |s|
101101
sss.header_dir = "react/renderer/components/safeareaview"
102102
end
103103

104-
ss.subspec "scrollview" do |sss|
105-
sss.source_files = podspec_sources(["react/renderer/components/scrollview/*.{m,mm,cpp,h}",
106-
"react/renderer/components/scrollview/platform/cxx/**/*.{m,mm,cpp,h}"],
107-
["react/renderer/components/scrollview/*.h",
108-
"react/renderer/components/scrollview/platform/cxx/**/*.h"])
109-
sss.exclude_files = "react/renderer/components/scrollview/tests"
110-
sss.header_dir = "react/renderer/components/scrollview"
111-
end
112-
113104
ss.subspec "text" do |sss|
114105
sss.source_files = podspec_sources(["react/renderer/components/text/*.{m,mm,cpp,h}",
115106
"react/renderer/components/text/platform/cxx/**/*.{m,mm,cpp,h}"],

0 commit comments

Comments
 (0)