Skip to content

Commit d85874f

Browse files
Saadnajmiclaude
andcommitted
ci: use microsoft-setup-toolchain for Hermes build jobs
Replace manual Xcode and Node.js setup in resolve-hermes, build-hermesc, and build-hermes-slice with the shared microsoft-setup-toolchain action for version consistency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 8537bbe commit d85874f

1 file changed

Lines changed: 24 additions & 19 deletions

File tree

.github/workflows/microsoft-prebuild-macos-core.yml

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,11 @@ jobs:
1717
filter: blob:none
1818
fetch-depth: 0
1919

20-
- name: Setup Xcode
21-
run: sudo xcode-select --switch /Applications/Xcode_16.2.app
22-
23-
- name: Set up Node.js
24-
uses: actions/setup-node@v4.4.0
20+
- name: Setup toolchain
21+
uses: ./.github/actions/microsoft-setup-toolchain
2522
with:
2623
node-version: '22'
27-
cache: yarn
28-
registry-url: https://registry.npmjs.org
24+
platform: macos
2925

3026
- name: Install npm dependencies
3127
run: yarn install
@@ -64,8 +60,11 @@ jobs:
6460
with:
6561
filter: blob:none
6662

67-
- name: Setup Xcode
68-
run: sudo xcode-select --switch /Applications/Xcode_16.2.app
63+
- name: Setup toolchain
64+
uses: ./.github/actions/microsoft-setup-toolchain
65+
with:
66+
platform: macos
67+
cache-npm-dependencies: ''
6968

7069
- name: Clone Hermes
7170
uses: actions/checkout@v4
@@ -101,21 +100,27 @@ jobs:
101100
fail-fast: false
102101
matrix:
103102
slice: [iphoneos, iphonesimulator, macosx, xros, xrsimulator]
103+
include:
104+
- slice: iphoneos
105+
platform: ios
106+
- slice: iphonesimulator
107+
platform: ios
108+
- slice: macosx
109+
platform: macos
110+
- slice: xros
111+
platform: visionos
112+
- slice: xrsimulator
113+
platform: visionos
104114
steps:
105115
- uses: actions/checkout@v4
106116
with:
107117
filter: blob:none
108118

109-
- name: Setup Xcode
110-
run: sudo xcode-select --switch /Applications/Xcode_16.2.app
111-
112-
- name: Download visionOS SDK
113-
if: ${{ matrix.slice == 'xros' || matrix.slice == 'xrsimulator' }}
114-
run: |
115-
sudo xcodebuild -runFirstLaunch
116-
sudo xcrun simctl list
117-
sudo xcodebuild -downloadPlatform visionOS
118-
sudo xcodebuild -runFirstLaunch
119+
- name: Setup toolchain
120+
uses: ./.github/actions/microsoft-setup-toolchain
121+
with:
122+
platform: ${{ matrix.platform }}
123+
cache-npm-dependencies: ''
119124

120125
- name: Clone Hermes
121126
uses: actions/checkout@v4

0 commit comments

Comments
 (0)