Skip to content

Commit ef64258

Browse files
Saadnajmiclaude
andcommitted
fix(ci): create recomposed xcframework at temp path before swap
The source frameworks live inside the old xcframework, so we can't delete it before creating the new one. Build to a temp path first, then swap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3b5be70 commit ef64258

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

.github/workflows/microsoft-resolve-hermes.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,17 @@ jobs:
8282
exit 0
8383
fi
8484
85-
# Remove old xcframework and create new one with macOS included
86-
rm -rf "$XCFW"
85+
# Create new xcframework at a temp path (can't overwrite in-place
86+
# because the source frameworks live inside the old xcframework)
87+
XCFW_NEW="hermes-destroot/Library/Frameworks/universal/hermes-new.xcframework"
8788
echo "Creating new universal xcframework with ${#FRAMEWORKS[@]} frameworks..."
8889
xcodebuild -create-xcframework "${FRAMEWORKS[@]}" \
89-
-output "$XCFW" \
90+
-output "$XCFW_NEW" \
9091
-allow-internal-distribution
9192
92-
# Clean up standalone macOS dir (now included in universal)
93+
# Swap in the new xcframework and clean up
94+
rm -rf "$XCFW"
95+
mv "$XCFW_NEW" "$XCFW"
9396
rm -rf hermes-destroot/Library/Frameworks/macosx
9497
9598
echo "=== Recomposed xcframework ==="

0 commit comments

Comments
 (0)