Commit f5ee485
committed
fix(podspec): comment out duplicate scrollview subspec in React-FabricComponents
# [macOS
The `scrollview` subspec is declared in BOTH `React-Fabric.podspec` and
`React-FabricComponents.podspec`, with overlapping `source_files`:
React-Fabric.podspec:
react/renderer/components/scrollview/**/*.{m,mm,cpp,h} (recursive)
React-FabricComponents.podspec:
react/renderer/components/scrollview/*.{m,mm,cpp,h}
react/renderer/components/scrollview/platform/cxx/**/*
Both globs include the same top-level files (ScrollViewShadowNode.cpp,
BaseScrollViewProps.cpp, ScrollEvent.cpp, etc.). After `pod install`,
those source files end up in both the React-Fabric and React-FabricComponents
Pods targets.
What breaks:
- Consumers that link both libraries (e.g. via `-all_load`) hit
duplicate symbol errors at link time.
- Consumers that deduplicate by hand by dropping scrollview from one
target break differently: React-Fabric's
mounting/internal/CullingContext.cpp references ScrollViewShadowNode,
so if the dedup drops it from React-Fabric, link fails with
`Undefined symbols: ScrollViewShadowNode`.
Comment out (rather than delete) the duplicate scrollview subspec in
React-FabricComponents, using the macOS diff-tag convention. The
recursive glob in React-Fabric.podspec's scrollview subspec already
covers everything FabricComponents was listing
(top-level files + scrollview/platform/cxx/**/*).
# macOS]1 parent eb3bccb commit f5ee485
1 file changed
Lines changed: 19 additions & 8 deletions
Lines changed: 19 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
112 | 123 | | |
113 | 124 | | |
114 | 125 | | |
| |||
0 commit comments