chore: remove RCTAddressSanitizerCrashManager#2395
Merged
Saadnajmi merged 1 commit intomicrosoft:mainfrom Mar 4, 2025
Merged
Conversation
tido64
approved these changes
Mar 4, 2025
Saadnajmi
force-pushed
the
remove-asan-module
branch
from
752cb00 to
d278deb
Compare
Saadnajmi
force-pushed
the
remove-asan-module
branch
from
d278deb to
b484b0e
Compare
This was referenced Mar 4, 2025
Saadnajmi
added a commit
that referenced
this pull request
Mar 4, 2025
Saadnajmi
added a commit
that referenced
this pull request
Mar 4, 2025
Saadnajmi
added a commit
that referenced
this pull request
Mar 4, 2025
Saadnajmi
added a commit
that referenced
this pull request
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This module is flagged internally by our static analysis. This module and test was added to test that ASAN was actually enabled and would crash on unsafe code. This meant checking in unsafe code as a test, which is now flagged now that we build from source internally. We don't need this module and test anymore, and we never had any automated tests that actually checked that this crashes. Let's just delete it.
Test Plan:
CI should pass.