Skip to content

Commit 0487b7a

Browse files
authored
fix(security): avoid missing buffer bounds check in uuid (#2752)
Also addresses the following vulnerabilities: - CVE-2026-41650 - CVE-2026-41672 - CVE-2026-41673 - CVE-2026-41674 - CVE-2026-41675 - GHSA-w5hq-g745-h8pq
1 parent 0686296 commit 0487b7a

3 files changed

Lines changed: 26 additions & 40 deletions

File tree

packages/app/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,9 @@
8989
"@rnx-kit/react-native-host": "^0.5.15",
9090
"@rnx-kit/tools-react-native": "^2.1.0",
9191
"ajv": "^8.0.0",
92-
"fast-xml-parser": "^5.3.4",
92+
"fast-xml-parser": "^5.7.0",
9393
"prompts": "^2.4.0",
94-
"semver": "^7.3.5",
95-
"uuid": "^11.0.0"
94+
"semver": "^7.5.2"
9695
},
9796
"devDependencies": {
9897
"@babel/core": "^7.25.2",

packages/app/windows/project.mjs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// @ts-check
22
import { resolveCommunityCLI } from "@rnx-kit/tools-react-native/context";
33
import { XMLParser } from "fast-xml-parser";
4+
import { randomUUID } from "node:crypto";
45
import * as nodefs from "node:fs";
56
import * as path from "node:path";
67
import { URL, fileURLToPath } from "node:url";
7-
import { v5 as uuidv5 } from "uuid";
88
import {
99
findNearest,
1010
getPackageVersion,
@@ -28,8 +28,6 @@ import * as colors from "../scripts/utils/colors.mjs";
2828
* } from "../scripts/types.js";
2929
*/
3030

31-
const uniqueFilterIdentifier = "e48dc53e-40b1-40cb-970a-f89935452892";
32-
3331
/**
3432
* Returns whether specified object is Error-like.
3533
* @param {unknown} e
@@ -152,10 +150,9 @@ function generateContentItems(
152150
normalizePath(
153151
source ? path.relative(source, resource) : path.basename(resource)
154152
);
155-
const id = uuidv5(filter, uniqueFilterIdentifier);
156153
assetFilters.push(
157154
`<Filter Include="${filter}">`,
158-
` <UniqueIdentifier>{${id}}</UniqueIdentifier>`,
155+
` <UniqueIdentifier>{${randomUUID()}}</UniqueIdentifier>`,
159156
`</Filter>`
160157
);
161158

yarn.lock

Lines changed: 22 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2584,10 +2584,10 @@ __metadata:
25842584
languageName: node
25852585
linkType: hard
25862586

2587-
"@nodable/entities@npm:^1.1.0":
2588-
version: 1.1.0
2589-
resolution: "@nodable/entities@npm:1.1.0"
2590-
checksum: 10c0/ff9b8d515d08ff8a5b83f587bc4a2482508250ac051d0967a8c77da3813cc7aae23d8ce8654c97a948536ca73387300ede734ff7c8ae61461220dca09a2911ec
2587+
"@nodable/entities@npm:^2.1.0":
2588+
version: 2.1.0
2589+
resolution: "@nodable/entities@npm:2.1.0"
2590+
checksum: 10c0/5a4cba2b61a5b6c726328b18b1de6d033cae4a658a118644bf31e0bcbda126ea7b69385043dc556cf1ed859b9ca220e82b81b5e5c48ef1b519fb8ec104575dee
25912591
languageName: node
25922592
linkType: hard
25932593

@@ -5502,16 +5502,16 @@ __metadata:
55025502
linkType: hard
55035503

55045504
"@xmldom/xmldom@npm:^0.8.8":
5505-
version: 0.8.12
5506-
resolution: "@xmldom/xmldom@npm:0.8.12"
5507-
checksum: 10c0/b733c84292d1bee32ef21a05aba8f9063456b51a54068d0b4a1abf5545156ee0b9894b7ae23775b5881b11c35a8a03871d1b514fb7e1b11654cdbee57e1c2707
5505+
version: 0.8.13
5506+
resolution: "@xmldom/xmldom@npm:0.8.13"
5507+
checksum: 10c0/06405ee6fffba631abf715a305ace338420ebcea8baf1317f19f2752f5c505952b7df45159908e7be8451a42faa54326b780616ab4d08242b20477b2973da24b
55085508
languageName: node
55095509
linkType: hard
55105510

55115511
"@xmldom/xmldom@npm:^0.9.0, @xmldom/xmldom@npm:^0.9.8, @xmldom/xmldom@npm:^0.x":
5512-
version: 0.9.9
5513-
resolution: "@xmldom/xmldom@npm:0.9.9"
5514-
checksum: 10c0/f1ecf6cd6926651a752d578fe662c10c47b8f8d98abe646f3318998283ac4a0e591161f89c8d1fc1822ae2524b82f8ff3de4ab396fba7ad7988f508cd5118e89
5512+
version: 0.9.10
5513+
resolution: "@xmldom/xmldom@npm:0.9.10"
5514+
checksum: 10c0/38a9c9b95450d7fccebc61371c8e0b90ceaae992886484108333d29ccbd2640e3555b6af012f15ce1beb5067aeb40486659b6183fad38af179e82d28028bfc5d
55155515
languageName: node
55165516
linkType: hard
55175517

@@ -8627,26 +8627,26 @@ __metadata:
86278627
languageName: node
86288628
linkType: hard
86298629

8630-
"fast-xml-builder@npm:^1.1.4":
8631-
version: 1.1.4
8632-
resolution: "fast-xml-builder@npm:1.1.4"
8630+
"fast-xml-builder@npm:^1.1.5":
8631+
version: 1.1.5
8632+
resolution: "fast-xml-builder@npm:1.1.5"
86338633
dependencies:
86348634
path-expression-matcher: "npm:^1.1.3"
8635-
checksum: 10c0/d5dfc0660f7f886b9f42747e6aa1d5e16c090c804b322652f65a5d7ffb93aa00153c3e1276cd053629f9f4c4f625131dc6886677394f7048e827e63b97b18927
8635+
checksum: 10c0/b814ba5559cb3140de46d2846045607ab4d4c0bfc312a49d22c91efb9f7cd7004971314841e5823eeb467a5bf403e3ade8371b7912200e111df027d42ae51715
86368636
languageName: node
86378637
linkType: hard
86388638

8639-
"fast-xml-parser@npm:^5.0.8, fast-xml-parser@npm:^5.3.4, fast-xml-parser@npm:^5.3.6":
8640-
version: 5.6.0
8641-
resolution: "fast-xml-parser@npm:5.6.0"
8639+
"fast-xml-parser@npm:^5.0.8, fast-xml-parser@npm:^5.3.4, fast-xml-parser@npm:^5.3.6, fast-xml-parser@npm:^5.7.0":
8640+
version: 5.7.1
8641+
resolution: "fast-xml-parser@npm:5.7.1"
86428642
dependencies:
8643-
"@nodable/entities": "npm:^1.1.0"
8644-
fast-xml-builder: "npm:^1.1.4"
8643+
"@nodable/entities": "npm:^2.1.0"
8644+
fast-xml-builder: "npm:^1.1.5"
86458645
path-expression-matcher: "npm:^1.5.0"
86468646
strnum: "npm:^2.2.3"
86478647
bin:
86488648
fxparser: src/cli/cli.js
8649-
checksum: 10c0/3c6c1084d5aab932d34549492e16ccf6ba1267daf21664933fb719fa86a20efc0a60a575720a314cd7b0a4a36b1842bd34b9a22240af98f63e98c83782d8bb2e
8649+
checksum: 10c0/b8b54e33060da5fc5ce26fdc73c4728f18415f9be9a774f1406b03265a5b411b742c39dba0127c3f0f31fad5b3ee11f51be79aa16df160f69fd5e4b902bfbb85
86508650
languageName: node
86518651
linkType: hard
86528652

@@ -13252,7 +13252,7 @@ __metadata:
1325213252
"@types/semver": "npm:^7.3.6"
1325313253
"@typescript/native-preview": "npm:^7.0.0-0"
1325413254
ajv: "npm:^8.0.0"
13255-
fast-xml-parser: "npm:^5.3.4"
13255+
fast-xml-parser: "npm:^5.7.0"
1325613256
js-yaml: "npm:^4.1.0"
1325713257
memfs: "npm:^4.0.0"
1325813258
minimatch: "npm:^10.0.0"
@@ -13261,9 +13261,8 @@ __metadata:
1326113261
prompts: "npm:^2.4.0"
1326213262
react: "npm:19.2.3"
1326313263
react-native: "npm:^0.85.0"
13264-
semver: "npm:^7.3.5"
13264+
semver: "npm:^7.5.2"
1326513265
suggestion-bot: "npm:^4.0.0"
13266-
uuid: "npm:^11.0.0"
1326713266
peerDependencies:
1326813267
"@callstack/react-native-visionos": 0.76 - 0.79
1326913268
"@expo/config-plugins": ">=5.0"
@@ -15540,15 +15539,6 @@ __metadata:
1554015539
languageName: node
1554115540
linkType: hard
1554215541

15543-
"uuid@npm:^11.0.0":
15544-
version: 11.1.0
15545-
resolution: "uuid@npm:11.1.0"
15546-
bin:
15547-
uuid: dist/esm/bin/uuid
15548-
checksum: 10c0/34aa51b9874ae398c2b799c88a127701408cd581ee89ec3baa53509dd8728cbb25826f2a038f9465f8b7be446f0fbf11558862965b18d21c993684297628d4d3
15549-
languageName: node
15550-
linkType: hard
15551-
1555215542
"uuid@npm:^13.0.0, uuid@npm:~13.0.0":
1555315543
version: 13.0.0
1555415544
resolution: "uuid@npm:13.0.0"

0 commit comments

Comments
 (0)