Skip to content

Commit fed94b8

Browse files
committed
fix(windows): fix ReactNativeWindowsDir not being overridable from Directory.Build.props
1 parent e19036c commit fed94b8

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

packages/app/windows/UWP/ReactTestApp.vcxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<ApplicationType>Windows Store</ApplicationType>
1616
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
1717
</PropertyGroup>
18+
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
1819
<PropertyGroup Label="ReactNativeWindowsProps">
1920
<ProjectRootDir Condition="'$(ProjectRootDir)'==''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'app.json'))</ProjectRootDir>
2021
<ReactAppWinDir Condition="'$(ReactAppWinDir)'==''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-test-app\package.json'))\node_modules\react-native-test-app\windows</ReactAppWinDir>
@@ -30,7 +31,6 @@
3031
<WindowsTargetPlatformVersion Condition="'$(WindowsTargetPlatformVersion)'==''">10.0</WindowsTargetPlatformVersion>
3132
<WindowsTargetPlatformMinVersion Condition="'$(WindowsTargetPlatformMinVersion)'==''">10.0.17763.0</WindowsTargetPlatformMinVersion>
3233
</PropertyGroup>
33-
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
3434
<ItemGroup Label="ProjectConfigurations">
3535
<ProjectConfiguration Include="Debug|ARM64">
3636
<Configuration>Debug</Configuration>

packages/app/windows/Win32/ReactApp.vcxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<MinimumVisualStudioVersion>17.0</MinimumVisualStudioVersion>
1313
<AppxPackage>false</AppxPackage>
1414
</PropertyGroup>
15+
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
1516
<PropertyGroup Label="ReactNativeWindowsProps">
1617
<ProjectRootDir Condition="'$(ProjectRootDir)'==''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'app.json'))</ProjectRootDir>
1718
<ReactAppWinDir Condition="'$(ReactAppWinDir)'==''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-test-app\package.json'))\node_modules\react-native-test-app\windows</ReactAppWinDir>
@@ -22,7 +23,6 @@
2223
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)'==''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
2324
</PropertyGroup>
2425
<Import Project="$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.WindowsSdk.Default.props" />
25-
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
2626
<ItemGroup Label="ProjectConfigurations">
2727
<ProjectConfiguration Include="Debug|Win32">
2828
<Configuration>Debug</Configuration>

0 commit comments

Comments
 (0)