Skip to content

Commit 473a6d5

Browse files
Copilotanupriya13
andcommitted
Remove unused skipDeps and skipBuild parameters and fix formatting
Co-authored-by: anupriya13 <54227869+anupriya13@users.noreply.github.com>
1 parent e214378 commit 473a6d5

2 files changed

Lines changed: 7 additions & 19 deletions

File tree

packages/@react-native-windows/cli/src/commands/setupModuleWindows/__tests__/setupModuleWindows.test.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ describe('SetupModuleWindows', () => {
2020
const mockOptions: SetupModuleWindowsOptions = {
2121
logging: false,
2222
telemetry: false,
23-
skipDeps: false,
24-
skipBuild: false,
2523
template: 'cpp-lib',
2624
};
2725

@@ -61,8 +59,6 @@ describe('SetupModuleWindows', () => {
6159
const options = {
6260
logging: true,
6361
telemetry: true,
64-
skipDeps: true,
65-
skipBuild: true,
6662
template: 'cpp-app' as const,
6763
};
6864

@@ -122,18 +118,18 @@ describe('SetupModuleWindows', () => {
122118
it('should throw error if no spec file exists', async () => {
123119
const glob = require('glob');
124120
glob.sync.mockReturnValue([]);
125-
121+
126122
const setup = new SetupModuleWindows('/test', {logging: true});
127123

128124
await expect((setup as any).checkForExistingSpec()).rejects.toThrow(
129-
'Create Spec File - TurboModule spec file not found. Please create a TurboModule spec file before running setup-module-windows.'
125+
'Create Spec File - TurboModule spec file not found. Please create a TurboModule spec file before running setup-module-windows.',
130126
);
131127
});
132128

133129
it('should accept valid TurboModule spec files', async () => {
134130
const glob = require('glob');
135131
glob.sync.mockReturnValue(['NativeTestModule.ts']);
136-
132+
137133
mockedFs.exists.mockResolvedValue(true);
138134
mockedFs.readFile.mockResolvedValue(`
139135
import type {TurboModule} from 'react-native/Libraries/TurboModule/RCTExport';
@@ -148,7 +144,9 @@ describe('SetupModuleWindows', () => {
148144

149145
const setup = new SetupModuleWindows('/test', {logging: true});
150146

151-
await expect((setup as any).checkForExistingSpec()).resolves.toBeUndefined();
147+
await expect(
148+
(setup as any).checkForExistingSpec(),
149+
).resolves.toBeUndefined();
152150
});
153151
});
154-
});
152+
});

packages/@react-native-windows/cli/src/commands/setupModuleWindows/setupModuleWindowsOptions.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ import type {CommandOption} from '@react-native-community/cli-types';
99
export interface SetupModuleWindowsOptions {
1010
logging?: boolean;
1111
telemetry?: boolean;
12-
skipDeps?: boolean;
13-
skipBuild?: boolean;
1412
template?: 'cpp-lib' | 'cpp-app';
1513
}
1614

@@ -24,14 +22,6 @@ export const setupModuleWindowsOptions: CommandOption[] = [
2422
description:
2523
'Disables sending telemetry that allows analysis of usage and failures of the react-native-windows CLI',
2624
},
27-
{
28-
name: '--skip-deps',
29-
description: 'Skip dependency upgrades (use current versions)',
30-
},
31-
{
32-
name: '--skip-build',
33-
description: 'Skip final build verification step',
34-
},
3525
{
3626
name: '--template [string]',
3727
description: 'Project template (cpp-lib or cpp-app)',

0 commit comments

Comments
 (0)