fix by looking in winget-cli

- microsoft/winget-cli#5932

Author: vineethkuttan

vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props

@@ -18,6 +18,16 @@
     <Warning Text="Property `RnwSdkDefaultsSet` was not set. Please ensure your project imports 'Microsoft.ReactNative.WindowsSdk.Default.props' before importing this prop sheet." />
   </Target>
 
+  <!--
+    App projects do not generate Windows Metadata. Explicitly set this to
+    prevent the CppWinRT NuGet target CppWinRTComputeGetResolvedWinMD from
+    trying to compute it, which can cause MSB4006 circular dependency errors
+    during parallel builds (see https://github.com/microsoft/cppwinrt/issues/950).
+  -->
+  <PropertyGroup Label="CppWinRT">
+    <CppWinRTGenerateWindowsMetadata Condition="'$(CppWinRTGenerateWindowsMetadata)' == ''">false</CppWinRTGenerateWindowsMetadata>
+  </PropertyGroup>
+
   <!-- Import common props sheets common to all Composition projects. -->
   <Import Project="$(MSBuildThisFileDirectory)Microsoft.ReactNative.Composition.Common.props" />
 

vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props

@@ -14,10 +14,10 @@
   </Target>
 
   <!--
-    Lib/module projects generate Windows Metadata, so set this before importing
-    Common props (which defaults it to false). This also prevents MSB4006
-    circular dependency errors in CppWinRT during parallel builds.
-    See https://github.com/microsoft/cppwinrt/issues/950.
+    Lib/module projects generate Windows Metadata. Explicitly set this to
+    prevent the CppWinRT NuGet target CppWinRTComputeGetResolvedWinMD from
+    trying to compute it, which can cause MSB4006 circular dependency errors
+    during parallel builds (see https://github.com/microsoft/cppwinrt/issues/950).
   -->
   <PropertyGroup Label="CppWinRT">
     <CppWinRTGenerateWindowsMetadata Condition="'$(CppWinRTGenerateWindowsMetadata)' == ''">true</CppWinRTGenerateWindowsMetadata>

vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props

@@ -12,15 +12,6 @@
 
   <PropertyGroup Label="CppWinRT">
     <CppWinRTVersion Condition="'$(CppWinRTVersion)' == '' Or $([MSBuild]::VersionLessThan('$(CppWinRTVersion)', '2.0.230706.1'))">2.0.230706.1</CppWinRTVersion>
-    <!--
-      Explicitly set CppWinRTGenerateWindowsMetadata to prevent the CppWinRT
-      NuGet target CppWinRTComputeGetResolvedWinMD from running.
-      That target can cause MSB4006 circular dependency errors during parallel
-      builds (see https://github.com/microsoft/cppwinrt/issues/950).
-      Default to false; lib/module projects that produce WinMD should override
-      this to true in their own props.
-    -->
-    <CppWinRTGenerateWindowsMetadata Condition="'$(CppWinRTGenerateWindowsMetadata)' == ''">false</CppWinRTGenerateWindowsMetadata>
   </PropertyGroup>
 
   <PropertyGroup Label="MSVC">

vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props

@@ -18,6 +18,16 @@
     <Warning Text="Property `RnwSdkDefaultsSet` was not set. Please ensure your project imports 'Microsoft.ReactNative.WindowsSdk.Default.props' before importing this prop sheet." />
   </Target>
 
+  <!--
+    App projects do not generate Windows Metadata. Explicitly set this to
+    prevent the CppWinRT NuGet target CppWinRTComputeGetResolvedWinMD from
+    trying to compute it, which can cause MSB4006 circular dependency errors
+    during parallel builds (see https://github.com/microsoft/cppwinrt/issues/950).
+  -->
+  <PropertyGroup Label="CppWinRT">
+    <CppWinRTGenerateWindowsMetadata Condition="'$(CppWinRTGenerateWindowsMetadata)' == ''">false</CppWinRTGenerateWindowsMetadata>
+  </PropertyGroup>
+
   <!-- Import common props sheets common to all UWP projects. -->
   <Import Project="$(MSBuildThisFileDirectory)Microsoft.ReactNative.Uwp.Common.props" />
 

vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props

@@ -15,10 +15,10 @@
   </Target>
 
   <!--
-    Lib/module projects generate Windows Metadata, so set this before importing
-    Common props (which defaults it to false). This also prevents MSB4006
-    circular dependency errors in CppWinRT during parallel builds.
-    See https://github.com/microsoft/cppwinrt/issues/950.
+    Lib/module projects generate Windows Metadata. Explicitly set this to
+    prevent the CppWinRT NuGet target CppWinRTComputeGetResolvedWinMD from
+    trying to compute it, which can cause MSB4006 circular dependency errors
+    during parallel builds (see https://github.com/microsoft/cppwinrt/issues/950).
   -->
   <PropertyGroup Label="CppWinRT">
     <CppWinRTGenerateWindowsMetadata Condition="'$(CppWinRTGenerateWindowsMetadata)' == ''">true</CppWinRTGenerateWindowsMetadata>