Skip to content

Commit ba24ca5

Browse files
author
Harini Malothu
committed
Fixed build errors
1 parent c7de3a5 commit ba24ca5

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

vnext/Shared/Shared.vcxitems

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -555,6 +555,7 @@
555555
<ClCompile Include="$(ReactNativeDir)\ReactCommon\reactperflogger\reactperflogger\ReactPerfettoLogger.cpp" />
556556
<ClCompile Include="$(ReactNativeDir)\ReactCommon\oscompat\OSCompatPosix.cpp" />
557557
<ClCompile Include="$(ReactNativeDir)\ReactCommon\oscompat\OSCompatWindows.cpp" />
558+
<ClCompile Include="$(ReactNativeDir)\ReactCommon\jsinspector-modern\network\NetworkReporter.cpp" />
558559
</ItemGroup>
559560
<ItemGroup>
560561
<None Include="$(MSBuildThisFileDirectory)tracing\rnw.wprp" />

vnext/Shared/Shared.vcxitems.filters

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,7 @@
343343
<ClCompile Include="$(ReactNativeDir)\ReactCommon\oscompat\OSCompatPosix.cpp" />
344344
<ClCompile Include="$(ReactNativeDir)\ReactCommon\oscompat\OSCompatWindows.cpp" />
345345
<ClCompile Include="$(MSBuildThisFileDirectory)..\Microsoft.ReactNative\Fabric\platform\react\renderer\textlayoutmanager\WindowsTextLayoutManager.cpp" />
346+
<ClCompile Include="$(ReactNativeDir)\ReactCommon\jsinspector-modern\network\NetworkReporter.cpp" />
346347
</ItemGroup>
347348
<ItemGroup>
348349
<Filter Include="Source Files">

vnext/stubs/double-conversion/double-conversion.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,12 @@ class StringBuilder {
2525
return m_ss.str().length();
2626
}
2727

28-
void Finalize() {
28+
char* Finalize() {
2929
std::string str = m_ss.str();
3030
memcpy(m_buffer, str.c_str(), str.length());
31-
}
31+
m_buffer[str.length()] = '\0'; // IMPORTANT: Add null terminator
32+
return m_buffer; // Returns char* that will convert to std::string
33+
}
3234

3335
char *m_buffer;
3436
std::stringstream m_ss;

0 commit comments

Comments
 (0)