Skip to content

Commit d65b9e3

Browse files
acoates-msacoates-ms
committed
fix border sometimes being created behind the background
1 parent d3f80e0 commit d65b9e3

12 files changed

Lines changed: 1846 additions & 752 deletions

‎packages/e2e-test-app-fabric/test/__image_snapshots__/view-component-test-test-ts-view-tests-view-box-sizing-2-snap.png‎

85 Bytes
Loading

‎packages/e2e-test-app-fabric/test/__image_snapshots__/view-component-test-test-ts-view-tests-views-can-have-outlines-2-snap.png‎

3.26 KB
Loading

‎packages/e2e-test-app-fabric/test/__snapshots__/ButtonComponentTest.test.ts.snap‎

Lines changed: 126 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,6 @@ exports[`Button Tests Buttons can be disabled 1`] = `
4848
"Visual Type": "SpriteVisual",
4949
"__Children": [
5050
{
51-
"Brush": {
52-
"Brush Type": "ColorBrush",
53-
"Color": "rgba(249, 249, 249, 77)",
54-
},
5551
"Offset": "0, 0, 0",
5652
"Size": "916, 37",
5753
"Visual Type": "SpriteVisual",
@@ -128,6 +124,15 @@ exports[`Button Tests Buttons can be disabled 1`] = `
128124
"Size": "1, 28",
129125
"Visual Type": "SpriteVisual",
130126
},
127+
{
128+
"Brush": {
129+
"Brush Type": "ColorBrush",
130+
"Color": "rgba(249, 249, 249, 77)",
131+
},
132+
"Offset": "0, 0, 0",
133+
"Size": "0, 0",
134+
"Visual Type": "SpriteVisual",
135+
},
131136
],
132137
},
133138
],
@@ -196,10 +201,6 @@ exports[`Button Tests Buttons can have accessibility labels 1`] = `
196201
"Visual Type": "SpriteVisual",
197202
"__Children": [
198203
{
199-
"Brush": {
200-
"Brush Type": "ColorBrush",
201-
"Color": "rgba(0, 122, 255, 255)",
202-
},
203204
"Offset": "0, 0, 0",
204205
"Size": "916, 37",
205206
"Visual Type": "SpriteVisual",
@@ -276,6 +277,15 @@ exports[`Button Tests Buttons can have accessibility labels 1`] = `
276277
"Size": "1, 28",
277278
"Visual Type": "SpriteVisual",
278279
},
280+
{
281+
"Brush": {
282+
"Brush Type": "ColorBrush",
283+
"Color": "rgba(0, 122, 255, 255)",
284+
},
285+
"Offset": "0, 0, 0",
286+
"Size": "0, 0",
287+
"Visual Type": "SpriteVisual",
288+
},
279289
],
280290
},
281291
],
@@ -330,10 +340,6 @@ exports[`Button Tests Buttons can have accessibility props 1`] = `
330340
],
331341
},
332342
"Visual Tree": {
333-
"Brush": {
334-
"Brush Type": "ColorBrush",
335-
"Color": "rgba(255, 255, 255, 179)",
336-
},
337343
"Comment": "accessibility_props",
338344
"Offset": "0, 0, 0",
339345
"Size": "916, 37",
@@ -411,6 +417,15 @@ exports[`Button Tests Buttons can have accessibility props 1`] = `
411417
"Size": "1, 28",
412418
"Visual Type": "SpriteVisual",
413419
},
420+
{
421+
"Brush": {
422+
"Brush Type": "ColorBrush",
423+
"Color": "rgba(255, 255, 255, 179)",
424+
},
425+
"Offset": "0, 0, 0",
426+
"Size": "0, 0",
427+
"Visual Type": "SpriteVisual",
428+
},
414429
{
415430
"Offset": "9, 9, 0",
416431
"Size": "898, 20",
@@ -476,10 +491,6 @@ exports[`Button Tests Buttons can have accessibility states 1`] = `
476491
"Visual Type": "SpriteVisual",
477492
"__Children": [
478493
{
479-
"Brush": {
480-
"Brush Type": "ColorBrush",
481-
"Color": "rgba(249, 249, 249, 77)",
482-
},
483494
"Offset": "0, 0, 0",
484495
"Size": "916, 37",
485496
"Visual Type": "SpriteVisual",
@@ -556,6 +567,15 @@ exports[`Button Tests Buttons can have accessibility states 1`] = `
556567
"Size": "1, 28",
557568
"Visual Type": "SpriteVisual",
558569
},
570+
{
571+
"Brush": {
572+
"Brush Type": "ColorBrush",
573+
"Color": "rgba(249, 249, 249, 77)",
574+
},
575+
"Offset": "0, 0, 0",
576+
"Size": "0, 0",
577+
"Visual Type": "SpriteVisual",
578+
},
559579
],
560580
},
561581
],
@@ -624,10 +644,6 @@ exports[`Button Tests Buttons can have custom colors 1`] = `
624644
"Visual Type": "SpriteVisual",
625645
"__Children": [
626646
{
627-
"Brush": {
628-
"Brush Type": "ColorBrush",
629-
"Color": "rgba(255, 59, 48, 255)",
630-
},
631647
"Offset": "0, 0, 0",
632648
"Size": "916, 37",
633649
"Visual Type": "SpriteVisual",
@@ -704,6 +720,15 @@ exports[`Button Tests Buttons can have custom colors 1`] = `
704720
"Size": "1, 28",
705721
"Visual Type": "SpriteVisual",
706722
},
723+
{
724+
"Brush": {
725+
"Brush Type": "ColorBrush",
726+
"Color": "rgba(255, 59, 48, 255)",
727+
},
728+
"Offset": "0, 0, 0",
729+
"Size": "0, 0",
730+
"Visual Type": "SpriteVisual",
731+
},
707732
],
708733
},
709734
],
@@ -742,10 +767,6 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 1`]
742767
],
743768
},
744769
"Visual Tree": {
745-
"Brush": {
746-
"Brush Type": "ColorBrush",
747-
"Color": "rgba(255, 255, 255, 179)",
748-
},
749770
"Comment": "accessible_false_button",
750771
"Offset": "0, 0, 0",
751772
"Size": "916, 37",
@@ -823,6 +844,15 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 1`]
823844
"Size": "1, 28",
824845
"Visual Type": "SpriteVisual",
825846
},
847+
{
848+
"Brush": {
849+
"Brush Type": "ColorBrush",
850+
"Color": "rgba(255, 255, 255, 179)",
851+
},
852+
"Offset": "0, 0, 0",
853+
"Size": "0, 0",
854+
"Visual Type": "SpriteVisual",
855+
},
826856
{
827857
"Offset": "9, 9, 0",
828858
"Size": "898, 20",
@@ -872,10 +902,6 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 2`]
872902
],
873903
},
874904
"Visual Tree": {
875-
"Brush": {
876-
"Brush Type": "ColorBrush",
877-
"Color": "rgba(255, 255, 255, 179)",
878-
},
879905
"Comment": "focusable_false_button",
880906
"Offset": "0, 0, 0",
881907
"Size": "916, 37",
@@ -953,6 +979,15 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 2`]
953979
"Size": "1, 28",
954980
"Visual Type": "SpriteVisual",
955981
},
982+
{
983+
"Brush": {
984+
"Brush Type": "ColorBrush",
985+
"Color": "rgba(255, 255, 255, 179)",
986+
},
987+
"Offset": "0, 0, 0",
988+
"Size": "0, 0",
989+
"Visual Type": "SpriteVisual",
990+
},
956991
{
957992
"Offset": "9, 9, 0",
958993
"Size": "898, 20",
@@ -987,10 +1022,6 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 3`]
9871022
],
9881023
},
9891024
"Visual Tree": {
990-
"Brush": {
991-
"Brush Type": "ColorBrush",
992-
"Color": "rgba(255, 255, 255, 179)",
993-
},
9941025
"Comment": "accessible_focusable_false_button",
9951026
"Offset": "0, 0, 0",
9961027
"Size": "916, 37",
@@ -1068,6 +1099,15 @@ exports[`Button Tests Buttons can have custom focusable and accessible props 3`]
10681099
"Size": "1, 28",
10691100
"Visual Type": "SpriteVisual",
10701101
},
1102+
{
1103+
"Brush": {
1104+
"Brush Type": "ColorBrush",
1105+
"Color": "rgba(255, 255, 255, 179)",
1106+
},
1107+
"Offset": "0, 0, 0",
1108+
"Size": "0, 0",
1109+
"Visual Type": "SpriteVisual",
1110+
},
10711111
{
10721112
"Offset": "9, 9, 0",
10731113
"Size": "898, 20",
@@ -1191,10 +1231,6 @@ exports[`Button Tests Buttons can have flexbox styling 1`] = `
11911231
"Visual Type": "SpriteVisual",
11921232
"__Children": [
11931233
{
1194-
"Brush": {
1195-
"Brush Type": "ColorBrush",
1196-
"Color": "rgba(255, 59, 48, 255)",
1197-
},
11981234
"Offset": "0, 0, 0",
11991235
"Size": "59, 37",
12001236
"Visual Type": "SpriteVisual",
@@ -1271,6 +1307,15 @@ exports[`Button Tests Buttons can have flexbox styling 1`] = `
12711307
"Size": "1, 28",
12721308
"Visual Type": "SpriteVisual",
12731309
},
1310+
{
1311+
"Brush": {
1312+
"Brush Type": "ColorBrush",
1313+
"Color": "rgba(255, 59, 48, 255)",
1314+
},
1315+
"Offset": "0, 0, 0",
1316+
"Size": "0, 0",
1317+
"Visual Type": "SpriteVisual",
1318+
},
12741319
],
12751320
},
12761321
],
@@ -1308,10 +1353,6 @@ exports[`Button Tests Buttons can have flexbox styling 1`] = `
13081353
"Visual Type": "SpriteVisual",
13091354
"__Children": [
13101355
{
1311-
"Brush": {
1312-
"Brush Type": "ColorBrush",
1313-
"Color": "rgba(52, 199, 89, 255)",
1314-
},
13151356
"Offset": "0, 0, 0",
13161357
"Size": "62, 37",
13171358
"Visual Type": "SpriteVisual",
@@ -1388,6 +1429,15 @@ exports[`Button Tests Buttons can have flexbox styling 1`] = `
13881429
"Size": "1, 28",
13891430
"Visual Type": "SpriteVisual",
13901431
},
1432+
{
1433+
"Brush": {
1434+
"Brush Type": "ColorBrush",
1435+
"Color": "rgba(52, 199, 89, 255)",
1436+
},
1437+
"Offset": "0, 0, 0",
1438+
"Size": "0, 0",
1439+
"Visual Type": "SpriteVisual",
1440+
},
13911441
],
13921442
},
13931443
],
@@ -1552,10 +1602,6 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
15521602
"Visual Type": "SpriteVisual",
15531603
"__Children": [
15541604
{
1555-
"Brush": {
1556-
"Brush Type": "ColorBrush",
1557-
"Color": "rgba(255, 59, 48, 255)",
1558-
},
15591605
"Offset": "0, 0, 0",
15601606
"Size": "59, 37",
15611607
"Visual Type": "SpriteVisual",
@@ -1632,6 +1678,15 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
16321678
"Size": "1, 28",
16331679
"Visual Type": "SpriteVisual",
16341680
},
1681+
{
1682+
"Brush": {
1683+
"Brush Type": "ColorBrush",
1684+
"Color": "rgba(255, 59, 48, 255)",
1685+
},
1686+
"Offset": "0, 0, 0",
1687+
"Size": "0, 0",
1688+
"Visual Type": "SpriteVisual",
1689+
},
16351690
],
16361691
},
16371692
],
@@ -1669,10 +1724,6 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
16691724
"Visual Type": "SpriteVisual",
16701725
"__Children": [
16711726
{
1672-
"Brush": {
1673-
"Brush Type": "ColorBrush",
1674-
"Color": "rgba(0, 122, 255, 255)",
1675-
},
16761727
"Offset": "0, 0, 0",
16771728
"Size": "105, 37",
16781729
"Visual Type": "SpriteVisual",
@@ -1749,6 +1800,15 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
17491800
"Size": "1, 28",
17501801
"Visual Type": "SpriteVisual",
17511802
},
1803+
{
1804+
"Brush": {
1805+
"Brush Type": "ColorBrush",
1806+
"Color": "rgba(0, 122, 255, 255)",
1807+
},
1808+
"Offset": "0, 0, 0",
1809+
"Size": "0, 0",
1810+
"Visual Type": "SpriteVisual",
1811+
},
17521812
],
17531813
},
17541814
],
@@ -1786,10 +1846,6 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
17861846
"Visual Type": "SpriteVisual",
17871847
"__Children": [
17881848
{
1789-
"Brush": {
1790-
"Brush Type": "ColorBrush",
1791-
"Color": "rgba(52, 199, 89, 255)",
1792-
},
17931849
"Offset": "0, 0, 0",
17941850
"Size": "62, 37",
17951851
"Visual Type": "SpriteVisual",
@@ -1866,6 +1922,15 @@ exports[`Button Tests Buttons can have flexbox styling with three buttons 1`] =
18661922
"Size": "1, 28",
18671923
"Visual Type": "SpriteVisual",
18681924
},
1925+
{
1926+
"Brush": {
1927+
"Brush Type": "ColorBrush",
1928+
"Color": "rgba(52, 199, 89, 255)",
1929+
},
1930+
"Offset": "0, 0, 0",
1931+
"Size": "0, 0",
1932+
"Visual Type": "SpriteVisual",
1933+
},
18691934
],
18701935
},
18711936
],
@@ -1923,10 +1988,6 @@ exports[`Button Tests Buttons have default styling 1`] = `
19231988
],
19241989
},
19251990
"Visual Tree": {
1926-
"Brush": {
1927-
"Brush Type": "ColorBrush",
1928-
"Color": "rgba(255, 255, 255, 179)",
1929-
},
19301991
"Comment": "button_default_styling",
19311992
"Offset": "0, 0, 0",
19321993
"Size": "916, 37",
@@ -2004,6 +2065,15 @@ exports[`Button Tests Buttons have default styling 1`] = `
20042065
"Size": "1, 28",
20052066
"Visual Type": "SpriteVisual",
20062067
},
2068+
{
2069+
"Brush": {
2070+
"Brush Type": "ColorBrush",
2071+
"Color": "rgba(255, 255, 255, 179)",
2072+
},
2073+
"Offset": "0, 0, 0",
2074+
"Size": "0, 0",
2075+
"Visual Type": "SpriteVisual",
2076+
},
20072077
{
20082078
"Offset": "9, 9, 0",
20092079
"Size": "898, 20",

0 commit comments

Comments
 (0)