Skip to content

Commit e73028f

Browse files
authored
Remove JSBigStringResourceDll, and unify WebsocketResource (#16159)
* Remove JSBigStringResourceDll, and unify WebsocketResource * Change files
1 parent 1a4ac57 commit e73028f

11 files changed

Lines changed: 8 additions & 112 deletions
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Remove JSBigStringResourceDll, and unify WebsocketResource",
4+
"packageName": "react-native-windows",
5+
"email": "30809111+acoates-ms@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

vnext/Desktop/JSBigStringResourceDll.cpp

Lines changed: 0 additions & 38 deletions
This file was deleted.

vnext/Desktop/JSBigStringResourceDll.h

Lines changed: 0 additions & 36 deletions
This file was deleted.

vnext/Desktop/React.Windows.Desktop.vcxproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,10 @@
132132
</ItemDefinitionGroup>
133133
<Import Project="$(ReactNativeWindowsDir)\PropertySheets\ReactCommunity.cpp.props" />
134134
<ItemGroup>
135-
<ClCompile Include="JSBigStringResourceDll.cpp" />
136135
<ClCompile Include="module.g.cpp" />
137136
<ClCompile Include="pch.cpp">
138137
<PrecompiledHeader>Create</PrecompiledHeader>
139138
</ClCompile>
140-
<ClCompile Include="WebSocketResourceFactory.cpp" />
141139
</ItemGroup>
142140
<ItemGroup>
143141
<ClInclude Include="..\Microsoft.ReactNative\DynamicReader.h">
@@ -179,7 +177,6 @@
179177
</ClInclude>
180178
<ClInclude Include="..\Microsoft.ReactNative\RedBoxErrorFrameInfo.h" />
181179
<ClInclude Include="..\Microsoft.ReactNative\RedBoxErrorInfo.h" />
182-
<ClInclude Include="JSBigStringResourceDll.h" />
183180
<ClInclude Include="pch.h" />
184181
</ItemGroup>
185182
<ItemGroup>

vnext/Desktop/React.Windows.Desktop.vcxproj.filters

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@
4141
<ClCompile Include="ABI\TestController.cpp">
4242
<Filter>ABI</Filter>
4343
</ClCompile>
44-
<ClCompile Include="JSBigStringResourceDll.cpp">
45-
<Filter>Source Files</Filter>
46-
</ClCompile>
4744
<ClCompile Include="module.g.cpp">
4845
<Filter>Generated Files</Filter>
4946
</ClCompile>
@@ -66,9 +63,6 @@
6663
</ClInclude>
6764
</ItemGroup>
6865
<ItemGroup>
69-
<ClInclude Include="JSBigStringResourceDll.h">
70-
<Filter>Header Files</Filter>
71-
</ClInclude>
7266
<ClInclude Include="Modules\TimingModule.h">
7367
<Filter>Header Files\Modules</Filter>
7468
</ClInclude>

vnext/Microsoft.ReactNative/Microsoft.ReactNative.vcxproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,6 @@
324324
</ClInclude>
325325
</ItemGroup>
326326
<ItemGroup>
327-
<ClCompile Include="Modules\CreateModules.cpp" />
328327
<ClCompile Include="Pch\pch.cpp">
329328
<PrecompiledHeader>Create</PrecompiledHeader>
330329
</ClCompile>

vnext/Microsoft.ReactNative/Microsoft.ReactNative.vcxproj.filters

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,6 @@
140140
<ClCompile Include="Utils\ValueUtils.cpp">
141141
<Filter>Utils</Filter>
142142
</ClCompile>
143-
<ClCompile Include="Modules\CreateModules.cpp">
144-
<Filter>Modules</Filter>
145-
</ClCompile>
146143
<ClCompile Include="Views\FrameworkElementTransferProperties.cpp" />
147144
<ClCompile Include="Views\ReactViewInstance.cpp" />
148145
</ItemGroup>

vnext/Microsoft.ReactNative/Modules/CreateModules.cpp

Lines changed: 0 additions & 24 deletions
This file was deleted.

vnext/Scripts/OfficeReact.Win32.nuspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@
5656

5757
<!-- Required for win32 -->
5858
<file src="$nugetroot$\inc\Shared\DevServerHelper.h" target="inc"/>
59-
<file src="$nugetroot$\inc\ReactWin32\JSBigStringResourceDll.h" target="inc"/>
6059
<file src="$nugetroot$\inc\react-native-win32.x64.def" target="inc"/>
6160
<file src="$nugetroot$\inc\react-native-win32.x86.def" target="inc"/>
6261

vnext/Shared/Shared.vcxitems

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@
170170
<ClCompile Include="$(MSBuildThisFileDirectory)V8JSIRuntimeHolder.cpp">
171171
<ExcludedFromBuild Condition="'$(UseV8)' != 'true'">true</ExcludedFromBuild>
172172
</ClCompile>
173+
<ClCompile Include="$(MSBuildThisFileDirectory)WebSocketResourceFactory.cpp" />
173174
</ItemGroup>
174175
<ItemGroup>
175176
<ClInclude Include="$(MSBuildThisFileDirectory)..\codegen\react\components\rnwcore\EventEmitters.h" />

0 commit comments

Comments
 (0)