Implement contextMenuHidden property for TextInput fabric architecture - #14804
Implement contextMenuHidden property for TextInput fabric architecture#14804HariniMalothu17 with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: HariniMalothu17 <185761277+HariniMalothu17@users.noreply.github.com>
|
@copilot are there any other shortcuts in contextMenuHidden property |
|
@copilot are there any other shortcuts in contextMenuHidden property |
The current implementation handles all standard Windows context menu shortcuts: Mouse: Right-click ✓ These cover the primary shortcuts recommended by Microsoft's accessibility guidelines. No additional shortcuts are needed for standard Windows context menu behavior.
The implementation is complete for standard context menu shortcuts. The current code handles:
These are the primary shortcuts used by Windows applications. Additional combinations like Ctrl+Shift+F10 exist but are rarely used and not necessary for standard context menu behavior. |
This PR implements the missing
contextMenuHiddenproperty for the fabric implementation of TextInput, bringing feature parity with the Paper implementation.Problem
The
contextMenuHiddenproperty was available in React Native Windows Paper viaTextInputViewManagerbut was not implemented in the fabric architecture. While the property was defined in the props structure (WindowsTextInputProps), the actual functionality to suppress context menus was missing from the fabricWindowsTextInputComponentView.Solution
Implemented context menu suppression by intercepting context menu triggers before they reach the RichEdit control:
Right-click handling
In
OnPointerReleased, whencontextMenuHiddenis true,WM_RBUTTONUPmessages are not forwarded to the RichEdit control:Keyboard shortcut handling
In
OnKeyDown, whencontextMenuHiddenis true, context menu keyboard shortcuts are intercepted:Testing
textinput-contextmenuhidden)Usage
Backward Compatibility
contextMenuHidden={true}is explicitly setcontextMenuHidden={false}) remains unchangedFixes #13123.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.