Fix INVALID_PARAMETER crash in ThreadPoolSchedulerWin::Post by adding null pointer guards#15154
Closed
Fix INVALID_PARAMETER crash in ThreadPoolSchedulerWin::Post by adding null pointer guards#15154
Conversation
Copilot
AI
changed the title
[WIP] [Paper][0.72][Watson Failure] caused by INVALID_PARAMETER_c000000d_Microsoft.ReactNative.dll!Mso::ThreadPoolSchedulerWin::Post
Fix INVALID_PARAMETER crash in ThreadPoolSchedulerWin::Post by adding null pointer guards
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a Watson failure crash caused by
INVALID_PARAMETER (c000000d)inMicrosoft.ReactNative.dll!Mso::ThreadPoolSchedulerWin::Post. The crash occurs when::SubmitThreadpoolWork()is called with a null or invalidTP_WORKhandle.Root Cause
The crash happens when:
CreateThreadpoolWork()fails during construction and returnsnullptrm_threadPoolWorkmemberThe stack trace shows the crash originates from line 157 in
threadPoolScheduler_win.cppwhere::SubmitThreadpoolWork(m_threadPoolWork.get())is called without validating the handle.Changes Made
Added defensive null pointer checks in four critical locations:
Post()method: GuardsSubmitThreadpoolWork()call and reverts thread count increment if work cannot be submittedAwaitTermination()method: GuardsWaitForThreadpoolWorkCallbacks()call to prevent similar crashesWaitForThreadPoolWorkCompletion()method: Guards against null handles in tracked work loopTrackThreadPoolWork()method: Prevents tracking of invalid handlesExample of the fix
Before:
After:
These changes ensure Windows ThreadPool APIs are never called with invalid parameters while maintaining proper state consistency.
Fixes #15099.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Microsoft Reviewers: Open in CodeFlow