Skip to content

Clean peer deps#15951

Merged
acoates-ms merged 5 commits intomicrosoft:mainfrom
acoates-ms:cleanPeerDeps
Apr 7, 2026
Merged

Clean peer deps#15951
acoates-ms merged 5 commits intomicrosoft:mainfrom
acoates-ms:cleanPeerDeps

Conversation

@acoates-ms
Copy link
Copy Markdown
Contributor

@acoates-ms acoates-ms commented Apr 7, 2026

Description

Fix all the missing peerDependency warnings in the monorepo, and make missing peerDependencies an error going forward.

Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested review from a team as code owners April 7, 2026 16:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Performance Test Results

Branch: cleanPeerDeps
Commit: 7aacddfa
Time: 2026-04-07T18:53:21.882Z
Tests: 161/161 passed

✅ Passed

161 scenario(s) across 28 suite(s) — no regressions

SectionList

Scenario Mean Median StdDev Renders vs Baseline
SectionList mount 4.90ms 4.00ms ±1.60ms 1 -20.0%
SectionList unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
SectionList rerender 11.40ms 10.00ms ±3.13ms 2 -4.8%
SectionList with-3-sections-15-items 4.90ms 5.00ms ±1.20ms 1 -9.1%
SectionList with-5-sections-50-items 5.70ms 5.00ms ±1.77ms 1 -16.7%
SectionList with-10-sections-200-items 6.40ms 5.00ms ±2.99ms 1 -9.1%
SectionList with-20-sections-200-items 5.10ms 4.50ms ±1.85ms 1 -10.0%
SectionList with-section-separator 3.00ms 2.50ms ±1.83ms 1 +25.0%
SectionList with-item-separator 2.20ms 2.00ms ±0.79ms 1 +0.0%
SectionList with-header-footer 2.00ms 2.00ms ±0.82ms 1 +0.0%
SectionList with-section-footer 2.40ms 1.50ms ±2.76ms 1 -25.0%
SectionList with-sticky-section-headers 1.70ms 1.50ms ±0.95ms 1 -25.0%
SectionList with-empty-list 0.50ms 0.50ms ±0.53ms 1 -50.0%
SectionList with-50-sections-1000-items 1.70ms 2.00ms ±0.48ms 1 +0.0%

FlatList

Scenario Mean Median StdDev Renders vs Baseline
FlatList mount 4.50ms 4.00ms ±0.97ms 1 +0.0%
FlatList unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
FlatList rerender 9.90ms 10.00ms ±2.08ms 2 +11.1%
FlatList with-10-items 5.20ms 5.00ms ±2.20ms 1 +25.0%
FlatList with-100-items 4.70ms 4.00ms ±0.95ms 1 -20.0%
FlatList with-500-items 4.50ms 4.00ms ±1.18ms 1 +0.0%
FlatList with-1000-items 4.10ms 4.00ms ±0.32ms 1 +0.0%
FlatList horizontal 3.90ms 4.00ms ±1.29ms 1 -20.0%
FlatList with-separator 1.60ms 2.00ms ±0.52ms 1 +0.0%
FlatList with-header-footer 1.30ms 1.00ms ±0.48ms 1 -50.0%
FlatList with-empty-list 0.50ms 0.50ms ±0.53ms 1 +0.0%
FlatList with-get-item-layout 2.20ms 1.50ms ±2.44ms 1 +50.0%
FlatList inverted 1.80ms 2.00ms ±0.42ms 1 +33.3%
FlatList with-num-columns 2.60ms 2.50ms ±0.70ms 1 -16.7%

TouchableOpacity

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity mount 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TouchableOpacity rerender 1.00ms 1.00ms ±0.82ms 2 +0.0%
TouchableOpacity custom-active-opacity 0.50ms 0.50ms ±0.53ms 1 -50.0%
TouchableOpacity disabled 0.70ms 0.50ms ±0.95ms 1 -50.0%
TouchableOpacity with-all-handlers 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity with-hit-slop 0.80ms 1.00ms ±0.42ms 1 +0.0%
TouchableOpacity with-delay 0.70ms 1.00ms ±0.48ms 1 +0.0%
TouchableOpacity nested 1.80ms 1.00ms ±1.55ms 1 +0.0%
TouchableOpacity multiple-10 6.27ms 6.00ms ±2.02ms 1 +0.0%
TouchableOpacity multiple-50 26.20ms 25.00ms ±4.09ms 1 -13.8%
TouchableOpacity multiple-100 46.13ms 44.00ms ±19.86ms 1 -12.0%

ScrollView

Scenario Mean Median StdDev Renders vs Baseline
ScrollView mount 0.40ms 0.00ms ±0.52ms 1 +0.0%
ScrollView unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ScrollView rerender 0.40ms 0.00ms ±0.52ms 2 -100.0%
ScrollView children-20 3.33ms 3.00ms ±1.63ms 1 -25.0%
ScrollView children-100 17.13ms 16.00ms ±3.74ms 1 +0.0%
ScrollView horizontal 3.30ms 3.00ms ±0.67ms 1 -25.0%
ScrollView sticky-headers 2.50ms 3.00ms ±0.71ms 1 +0.0%
ScrollView scroll-indicators 0.70ms 1.00ms ±0.48ms 1 +0.0%
ScrollView nested 1.50ms 1.00ms ±0.71ms 1 +0.0%
ScrollView content-container-style 0.70ms 1.00ms ±0.48ms 1 +0.0%
ScrollView children-500 23.33ms 23.00ms ±4.05ms 1 +21.1%

TouchableHighlight

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight mount 0.50ms 0.50ms ±0.53ms 1 +0.0%
TouchableHighlight unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TouchableHighlight rerender 0.80ms 1.00ms ±0.63ms 2 +0.0%
TouchableHighlight custom-underlay-color 0.50ms 0.50ms ±0.53ms 1 +Infinity%
TouchableHighlight custom-active-opacity 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight disabled 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight with-all-handlers 0.20ms 0.00ms ±0.42ms 1 +0.0%
TouchableHighlight with-hit-slop 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight nested-touchables 0.80ms 1.00ms ±0.42ms 1 +0.0%
TouchableHighlight multiple-touchables-10 2.30ms 2.00ms ±0.67ms 1 -33.3%
TouchableHighlight multiple-touchables-50 15.10ms 14.50ms ±4.79ms 1 +16.0%
TouchableHighlight multiple-touchables-100 29.00ms 22.00ms ±20.59ms 1 -2.2%

Pressable

Scenario Mean Median StdDev Renders vs Baseline
Pressable mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Pressable rerender 0.50ms 0.50ms ±0.53ms 2 +0.0%
Pressable with-all-handlers 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable with-style-function 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable disabled 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable with-hit-slop 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable nested 1.00ms 1.00ms ±0.00ms 1 +0.0%
Pressable multiple-10 3.27ms 3.00ms ±1.10ms 1 +0.0%
Pressable multiple-50 15.87ms 16.00ms ±2.85ms 1 +14.3%
Pressable multiple-100 17.47ms 12.00ms ±10.27ms 1 +0.0%

Modal

Scenario Mean Median StdDev Renders vs Baseline
Modal mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
Modal unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Modal rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
Modal slide-animation 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal fade-animation 0.20ms 0.00ms ±0.42ms 1 +0.0%
Modal transparent 0.40ms 0.00ms ±0.52ms 1 +0.0%
Modal with-callbacks 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal rich-content 1.50ms 1.50ms ±0.53ms 1 -25.0%
Modal with-accessibility 0.40ms 0.00ms ±0.52ms 1 +0.0%

Image

Scenario Mean Median StdDev Renders vs Baseline
Image mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Image unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Image rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
Image with-resize-mode 0.30ms 0.00ms ±0.48ms 1 +0.0%
Image with-border-radius 0.30ms 0.00ms ±0.48ms 1 +0.0%
Image with-tint-color 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-blur-radius 0.20ms 0.00ms ±0.42ms 1 +0.0%
Image with-accessibility 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image multiple-10 0.80ms 1.00ms ±0.41ms 1 +0.0%
Image multiple-50 3.27ms 3.00ms ±0.46ms 1 +0.0%
Image multiple-100 8.93ms 7.00ms ±2.60ms 1 -12.5%

ActivityIndicator

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator mount 0.00ms 0.00ms ±0.00ms 1 +0.0%
ActivityIndicator unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ActivityIndicator rerender 0.70ms 0.00ms ±1.57ms 2 +0.0%
ActivityIndicator size-large 0.00ms 0.00ms ±0.00ms 1 +0.0%
ActivityIndicator size-small 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator with-color 0.30ms 0.00ms ±0.48ms 1 +0.0%
ActivityIndicator not-animating 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-accessibility 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator multiple-10 0.87ms 1.00ms ±0.35ms 1 +0.0%
ActivityIndicator multiple-50 3.40ms 3.00ms ±0.63ms 1 -25.0%
ActivityIndicator multiple-100 7.93ms 7.00ms ±1.49ms 1 +0.0%

Switch

Scenario Mean Median StdDev Renders vs Baseline
Switch mount 0.40ms 0.00ms ±0.52ms 1 +0.0%
Switch unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Switch rerender 0.30ms 0.00ms ±0.48ms 2 -100.0%
Switch value-true 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch disabled 0.10ms 0.00ms ±0.32ms 1 +0.0%
Switch custom-colors 0.30ms 0.00ms ±0.48ms 1 +0.0%
Switch on-value-change 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch with-accessibility 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch multiple-10 2.27ms 2.00ms ±1.39ms 1 +0.0%
Switch multiple-50 10.27ms 10.00ms ±3.81ms 1 +11.1%
Switch multiple-100 19.20ms 21.00ms ±4.25ms 1 +31.3%

Button

Scenario Mean Median StdDev Renders vs Baseline
Button mount 0.40ms 0.00ms ±0.52ms 1 -100.0%
Button unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
Button rerender 1.00ms 1.00ms ±0.00ms 2 +0.0%
Button disabled 1.20ms 1.00ms ±1.75ms 1 +0.0%
Button with-color 0.50ms 0.50ms ±0.53ms 1 +0.0%
Button with-accessibility 0.70ms 1.00ms ±0.48ms 1 +0.0%
Button multiple-10 5.93ms 6.00ms ±2.09ms 1 +0.0%
Button multiple-50 21.73ms 23.00ms ±8.84ms 1 -14.8%
Button multiple-100 15.93ms 15.00ms ±4.37ms 1 -21.1%

TextInput

Scenario Mean Median StdDev Renders vs Baseline
TextInput mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
TextInput rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
TextInput multiline 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput with-value 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput styled 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput multiple-100 8.20ms 7.00ms ±2.54ms 1 +0.0%

View

Scenario Mean Median StdDev Renders vs Baseline
View mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
View unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
View rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
View nested-50 3.60ms 4.00ms ±0.83ms 1 +33.3%
View nested-100 8.80ms 9.00ms ±1.86ms 1 +28.6%
View shadow 0.20ms 0.00ms ±0.42ms 1 +0.0%
View border-radius 0.20ms 0.00ms ±0.42ms 1 +0.0%
View nested-500 18.20ms 12.00ms ±12.80ms 1 +20.0%

Text

Scenario Mean Median StdDev Renders vs Baseline
Text mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
Text unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Text rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
Text long-1000 0.10ms 0.00ms ±0.32ms 1 +0.0%
Text nested 0.10ms 0.00ms ±0.32ms 1 +0.0%
Text styled 0.20ms 0.00ms ±0.42ms 1 +0.0%
Text multiple-100 8.87ms 9.00ms ±2.17ms 1 +28.6%

SectionList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
SectionList native mount 6.60ms 6.41ms ±1.53ms 1 -1.5%

FlatList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
FlatList native mount 6.11ms 6.16ms ±0.99ms 1 -33.3%

TouchableHighlight.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight native mount 1.89ms 1.74ms ±0.33ms 1 -16.7%

TouchableOpacity.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity native mount 2.40ms 2.13ms ±0.95ms 1 -32.0%

Pressable.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Pressable native mount 2.12ms 1.99ms ±0.58ms 1 -20.8%

ScrollView.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ScrollView native mount 4.10ms 3.93ms ±0.37ms 1 -2.9%

ActivityIndicator.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator native mount 1.84ms 1.81ms ±0.21ms 1 -27.0%

TextInput.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TextInput native mount 2.79ms 2.77ms ±0.33ms 1 -32.3%

Switch.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Switch native mount 1.60ms 1.50ms ±0.23ms 1 -13.6%

Button.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Button native mount 2.71ms 2.47ms ±0.92ms 1 -5.0%

Modal.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Modal native mount 1.28ms 1.29ms ±0.14ms 1 +5.9%

Image.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Image native mount 2.29ms 2.07ms ±0.91ms 1 -8.4%

View.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
View native mount 1.60ms 1.37ms ±0.63ms 1 -4.2%

Text.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Text native mount 1.70ms 1.60ms ±0.35ms 1 -8.2%

@acoates-ms acoates-ms merged commit 669ddf1 into microsoft:main Apr 7, 2026
32 checks passed
@acoates-ms acoates-ms deleted the cleanPeerDeps branch April 7, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants