chore: dev to main merge#84
Merged
Merged
Conversation
fix: Resolved the code quality issue
Saswato-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes script termination in the Fabric database setup and data ingestion scripts by removing use of the interactive-only exit() helper and consistently using sys.exit(1) on unexpected errors.
Changes:
- Removed
exit(1)calls after error handling, leavingsys.exit(1)as the single termination path. - Added
import systofabric_data_ingester.pyto support thesys.exit(1)call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/scripts/fabric/fabric_database.py | Removes redundant exit(1) so the script uses sys.exit(1) consistently on unexpected errors. |
| infra/scripts/fabric/fabric_data_ingester.py | Imports sys and removes redundant exit(1) to ensure consistent, non-interactive script termination. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
May 25, 2026
Avijit-Microsoft
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes minor improvements to error handling in the Fabric data ingestion and database setup scripts. The main change is to consistently use
sys.exit(1)instead of the built-inexit(1)for terminating the script after an unexpected error, and to ensure thesysmodule is imported where needed.Error handling improvements:
exit(1)withsys.exit(1)in bothfabric_data_ingester.pyandfabric_database.pyto standardize script termination on errors. [1] [2]import systofabric_data_ingester.pyto support the use ofsys.exit(1).Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information