Fix CORS security vulnerability#2615
Open
imatiach-msft wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to remediate a wildcard CORS vulnerability (CWE-942) by defaulting PublicVMEnvironment and LocalIPythonEnvironment to restrictive CORS allowlists, with an allow_all_origins escape hatch on FlaskHelper.
Changes:
- Add
allow_all_originsparameter toFlaskHelperto optionally preserve wildcard CORS. - Restrict CORS in
PublicVMEnvironmentto a computed origin based onservice.ip/service.portunless overridden. - Restrict CORS in
LocalIPythonEnvironmenttolocalhost/127.0.0.1origins based onservice.portunless overridden.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
rai_core_flask/rai_core_flask/flask_helper.py |
Introduces the allow_all_origins flag on the core Flask helper service object. |
rai_core_flask/rai_core_flask/environments/public_vm_environment.py |
Applies the new flag and adds a restrictive CORS policy by default for public VM detection. |
rai_core_flask/rai_core_flask/environments/local_ipython_environment.py |
Applies the new flag and adds a restrictive CORS policy by default for local IPython detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fc655ed to
33f6fec
Compare
253a574 to
4d89758
Compare
4d89758 to
201c405
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes CWE-942 (Wildcard CORS) by defaulting to restrictive CORS policy while preserving backward compatibility via opt-in parameter.
Checklist