Skip to content

fix(grafana): use drop metric for destination pod panel#2268

Closed
SumiReCord wants to merge 1 commit into
microsoft:mainfrom
SumiReCord:fix/grafana-drop-metric
Closed

fix(grafana): use drop metric for destination pod panel#2268
SumiReCord wants to merge 1 commit into
microsoft:mainfrom
SumiReCord:fix/grafana-drop-metric

Conversation

@SumiReCord

Copy link
Copy Markdown

Description

Fix the Grafana panel query for "Dropped pps per Destination pod".
The panel title indicates dropped packets, but the query was using networkobservability_adv_forward_count.

Related Issue

N/A

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

I don't have a live Grafana environment to capture screenshots.
However, I have verified the fix logically:

  • Observed issue: The panel titled "Dropped pps" was using networkobservability_adv_forward_count, which measures forwarded (successful) traffic.
  • Fix: Changed the metric to the correct one for dropped packets.
  • The change is a straightforward query update based on the metric definitions.

Additional Notes

N/A


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@SumiReCord
SumiReCord requested a review from a team as a code owner April 30, 2026 13:41
@SumiReCord
SumiReCord requested review from ibezrukavyi and rbtr April 30, 2026 13:41
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions Bot added the meta/waiting-for-author Blocked and waiting on the author label Jun 2, 2026
@SumiReCord

Copy link
Copy Markdown
Author

Hi @rbtr and @ibezrukavyi, just bumping this thread to prevent it from being automatically closed. Whenever either of you has a chance to take a quick look, that would be awesome. Thanks!

@rbtr rbtr removed the meta/waiting-for-author Blocked and waiting on the author label Jun 2, 2026

@nddq nddq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@nddq nddq closed this Jun 2, 2026
@nddq nddq reopened this Jun 2, 2026
@nddq
nddq enabled auto-merge June 2, 2026 21:04
auto-merge was automatically disabled June 3, 2026 10:36

Head branch was pushed to by a user without write access

@SumiReCord
SumiReCord force-pushed the fix/grafana-drop-metric branch from 2990ea9 to c30dc8f Compare June 3, 2026 10:36
Signed-off-by: sumirecord <42767467+SumiReCord@users.noreply.github.com>
@SumiReCord
SumiReCord force-pushed the fix/grafana-drop-metric branch from c30dc8f to 7120ace Compare June 4, 2026 09:14
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions Bot added the meta/waiting-for-author Blocked and waiting on the author label Jul 5, 2026
@github-actions

Copy link
Copy Markdown

Pull request closed due to inactivity.

@github-actions github-actions Bot closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta/waiting-for-author Blocked and waiting on the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants