fixup! chore(suggestion-bot): move into repo

tido64 · tido64 · commit 5d2cc90b4e1c · 2026-04-07T10:44:41.000+02:00
diff --git a/.changeset/clean-towns-leave.md b/.changeset/clean-towns-leave.md
@@ -0,0 +1,5 @@
+---
+"suggestion-bot": patch
+---
+
+Publish from rnx-kit
diff --git a/docsite/generate.js b/docsite/generate.js
@@ -2,6 +2,8 @@
 const fs = require("node:fs");
 const path = require("node:path");
 
+const UTF_8 = /** @type {const} */ ({ encoding: "utf-8" });
+
 const badges = [
   "https://github\\.com/microsoft/rnx-kit/actions/workflows",
   "https://img\\.shields\\.io",
@@ -12,6 +14,7 @@ const badgesRE = new RegExp(
   "g"
 );
 
+const localImagesRE = /!\[(.*?)\]\(\.\/(.*?)\)/g;
 const titleRE = /# @rnx-kit\/(.*)/;
 
 function copyContributing() {
@@ -33,19 +36,22 @@ function generateToolsSidebar() {
       continue;
     }
 
-    const content = fs.readFileSync(manifest, { encoding: "utf-8" });
-    if (JSON.parse(content).private) {
+    if (JSON.parse(fs.readFileSync(manifest, UTF_8)).private) {
       continue;
     }
 
     const output = path.join("docs", "tools", `${pkg}.md`);
     if (!fs.existsSync(output)) {
-      const content = fs.readFileSync(readme, { encoding: "utf-8" });
+      const content = fs.readFileSync(readme, UTF_8);
       fs.writeFileSync(
         output,
         content
           .replace(titleRE, "# $1") // Remove scope from title
           .replace(badgesRE, "") // Remove badges
+          .replace(
+            localImagesRE,
+            `![$1](${path.join("..", "..", path.dirname(readme), "$2")})`
+          )
       );
     }
 
diff --git a/package.json b/package.json
@@ -51,7 +51,7 @@
     "nx": "patch:nx@npm%3A22.5.4#~/.yarn/patches/nx-npm-22.5.4-3d43ac9c10.patch",
     "oxfmt": "catalog:",
     "oxlint": "catalog:",
-    "suggestion-bot": "^4.0.0",
+    "suggestion-bot": "workspace:*",
     "typescript": "catalog:"
   },
   "resolutions": {
diff --git a/packages/suggestion-bot/.gitignore b/packages/suggestion-bot/.gitignore
@@ -0,0 +1,2 @@
+*.d.ts
+*.d.ts.map
diff --git a/packages/suggestion-bot/README.md b/packages/suggestion-bot/README.md
@@ -1,11 +1,11 @@
 # suggestion-bot
 
-[![build](https://github.com/tido64/suggestion-bot/actions/workflows/build.yml/badge.svg)](https://github.com/tido64/suggestion-bot/actions/workflows/build.yml)
+[![Build](https://github.com/microsoft/rnx-kit/actions/workflows/build.yml/badge.svg)](https://github.com/microsoft/rnx-kit/actions/workflows/build.yml)
 [![npm version](https://img.shields.io/npm/v/suggestion-bot)](https://www.npmjs.com/package/suggestion-bot)
 
 `suggestion-bot` submits code reviews with suggestions based on your diffs.
 
-![screenshot of code review with suggestions](docs/screenshot.png)
+![screenshot of code review with suggestions](./docs/screenshot.png)
 
 ## Usage
 
@@ -45,8 +45,7 @@ If your CI is hosted by Azure DevOps, replace `GITHUB_TOKEN` with
 -- or --
 
 - Host your code on [Azure DevOps](https://dev.azure.com/)
-- An Azure DevOps
-  [personal access token](https://docs.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate?view=azure-devops&tabs=preview-page)
+- An Azure DevOps [personal access token][ado-personal-access-token]
 
 ## Recipes
 
@@ -73,11 +72,11 @@ If your CI is hosted by Azure DevOps, replace `GITHUB_TOKEN` with
        runs-on: ubuntu-latest
        steps:
          - name: Set up Node.js
-           uses: actions/setup-node@v1
+           uses: actions/setup-node@v6
            with:
-             node-version: 18
+             node-version: 24
          - name: Checkout
-           uses: actions/checkout@v2
+           uses: actions/checkout@v6
          - name: Install
            run: yarn
          - name: ClangFormat
@@ -89,9 +88,7 @@ If your CI is hosted by Azure DevOps, replace `GITHUB_TOKEN` with
 
 ### Using `suggestion-bot` with `clang-format`
 
-Use
-[`clang-format-diff`](https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting)
-to format only changed files:
+Use [`clang-format-diff`][] to format only changed files:
 
 ```sh
 curl --silent --show-error --remote-name https://raw.githubusercontent.com/llvm/llvm-project/release/10.x/clang/tools/clang-format/clang-format-diff.py
@@ -102,8 +99,8 @@ git diff --unified=0 --no-color @^ \
 
 ### Using `suggestion-bot` with Prettier
 
-We must first write a script that pipes [Prettier](https://prettier.io/)'s
-output to `diff` so we can feed it to `suggestion-bot` later.
+We must first write a script that pipes [Prettier][]'s output to `diff` so we
+can feed it to `suggestion-bot` later.
 
 ```js
 #!/usr/bin/env node
@@ -131,3 +128,9 @@ Node:
 ```sh
 node scripts/prettier-diff.mjs $(git ls-files '*.js')
 ```
+
+<!-- References -->
+
+[Prettier]: https://prettier.io/
+[`clang-format-diff`]: https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
+[ado-personal-access-token]: https://docs.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate?view=azure-devops&tabs=preview-page
diff --git a/packages/suggestion-bot/cli.js b/packages/suggestion-bot/cli.js
@@ -1,12 +1,5 @@
 #!/usr/bin/env node
 
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
-
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { fileURLToPath, URL } from "node:url";
diff --git a/packages/suggestion-bot/package.json b/packages/suggestion-bot/package.json
@@ -1,6 +1,6 @@
 {
   "name": "suggestion-bot",
-  "version": "0.0.1-dev",
+  "version": "4.0.3",
   "description": "suggestion-bot submits code reviews with suggestions based on your diffs",
   "keywords": [
     "code review",
@@ -10,15 +10,16 @@
     "review",
     "suggestion"
   ],
-  "homepage": "https://github.com/tido64/suggestion-bot#readme",
+  "homepage": "https://github.com/microsoft/rnx-kit/tree/main/packages/suggestion-bot#readme",
   "license": "MIT",
   "author": {
-    "name": "Tommy Nguyen",
-    "email": "4123478+tido64@users.noreply.github.com"
+    "name": "Microsoft Open Source",
+    "email": "microsoftopensource@users.noreply.github.com"
   },
   "repository": {
     "type": "git",
-    "url": "https://github.com/tido64/suggestion-bot.git"
+    "url": "https://github.com/microsoft/rnx-kit",
+    "directory": "packages/suggestion-bot"
   },
   "bin": "cli.js",
   "files": [
@@ -38,12 +39,13 @@
     "./package.json": "./package.json"
   },
   "scripts": {
-    "build": "yarn clean && yarn lint && tsc",
+    "//build": "We run `tsgo` directly because we don't want to output to `lib`",
+    "build": "yarn clean && tsgo",
     "clean": "git clean -dfqx -- src/ test/",
-    "format": "oxfmt $(git ls-files '*.js' '*.json' '*.md' '*.ts' '*.yml' ':!:.yarn/**/*.cjs')",
-    "lint": "oxlint $(git ls-files '*.js' ':!:*.config.js' ':!:.yarn/**/*.js')",
+    "format": "rnx-kit-scripts format",
+    "lint": "rnx-kit-scripts lint",
     "suggest": "suggestion-bot",
-    "test": "node --test --experimental-test-coverage $(git ls-files 'test/*.test.js')"
+    "test": "rnx-kit-scripts test"
   },
   "dependencies": {
     "@octokit/core": "^7.0.0",
@@ -52,24 +54,11 @@
     "parse-diff": "^0.11.0"
   },
   "devDependencies": {
-    "@rnx-kit/oxlint-config": "^1.0.2",
-    "@rnx-kit/tsconfig": "^3.0.0",
-    "@types/node": "^24.0.0",
-    "oxfmt": "^0.40.0",
-    "oxlint": "^1.51.0",
-    "semantic-release": "^25.0.0",
-    "typescript": "^5.0.0"
-  },
-  "resolutions": {
-    "@microsoft/eslint-plugin-sdl/eslint-plugin-n": "^17.10.3",
-    "@microsoft/eslint-plugin-sdl/eslint-plugin-react": "^7.37.3",
-    "@semantic-release/npm/npm": "link:."
-  },
-  "release": {
-    "extends": "./.github/semantic-release.json"
+    "@rnx-kit/scripts": "*",
+    "@rnx-kit/tsconfig": "*",
+    "@types/node": "^24.0.0"
   },
   "engines": {
     "node": ">=20.9"
-  },
-  "packageManager": "yarn@4.12.0"
+  }
 }
diff --git a/packages/suggestion-bot/src/AzureDevOpsClient.js b/packages/suggestion-bot/src/AzureDevOpsClient.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 import * as azdevapi from "azure-devops-node-api";
 import { makeComments } from "./makeComments.js";
diff --git a/packages/suggestion-bot/src/GitHubClient.js b/packages/suggestion-bot/src/GitHubClient.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 import * as octokit_core from "@octokit/core";
 import { restEndpointMethods } from "@octokit/plugin-rest-endpoint-methods";
diff --git a/packages/suggestion-bot/src/helpers.js b/packages/suggestion-bot/src/helpers.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 
 /**
diff --git a/packages/suggestion-bot/src/index.js b/packages/suggestion-bot/src/index.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 
 /**
@@ -40,6 +34,7 @@ async function getClient() {
  * @param {Options=} options
  * @returns {Promise<void>}
  */
+// oxlint-disable-next-line no-default-export
 export default async function suggest(diff, options = {}) {
   const { makeReview } = await getClient();
   try {
diff --git a/packages/suggestion-bot/src/makeComments.js b/packages/suggestion-bot/src/makeComments.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 import parseDiff from "parse-diff";
 import { trimQuotes } from "./helpers.js";
diff --git a/packages/suggestion-bot/test/AzureDevOpsClient.test.js b/packages/suggestion-bot/test/AzureDevOpsClient.test.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 
 import { deepEqual, equal, fail, rejects } from "node:assert/strict";
diff --git a/packages/suggestion-bot/test/GitHubClient.test.js b/packages/suggestion-bot/test/GitHubClient.test.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 
 import { deepEqual, equal, fail, match, rejects } from "node:assert/strict";
diff --git a/packages/suggestion-bot/test/__fixtures__.js b/packages/suggestion-bot/test/__fixtures__.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 /* node:coverage disable */
 
diff --git a/packages/suggestion-bot/test/makeComment.test.js b/packages/suggestion-bot/test/makeComment.test.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 
 import { deepEqual } from "node:assert/strict";
diff --git a/packages/suggestion-bot/test/trimQuotes.test.js b/packages/suggestion-bot/test/trimQuotes.test.js
@@ -1,9 +1,3 @@
-//
-// Copyright (c) Tommy Nguyen
-//
-// This source code is licensed under the MIT license found in the
-// LICENSE file in the root directory of this source tree.
-//
 // @ts-check
 
 import { equal } from "node:assert/strict";
diff --git a/scripts/lint-tsconfig.ts b/scripts/lint-tsconfig.ts
@@ -22,7 +22,8 @@ function verifyEmit({
 }: TypeScriptConfig): ErrorType | null {
   return Array.isArray(include) &&
     compilerOptions?.rootDir !== include[0] &&
-    !compilerOptions?.noEmit
+    !compilerOptions?.noEmit &&
+    !compilerOptions?.emitDeclarationOnly
     ? "missing-rootDir-or-noEmit"
     : null;
 }
diff --git a/yarn.lock b/yarn.lock
@@ -16563,7 +16563,7 @@ __metadata:
     nx: "patch:nx@npm%3A22.5.4#~/.yarn/patches/nx-npm-22.5.4-3d43ac9c10.patch"
     oxfmt: "catalog:"
     oxlint: "catalog:"
-    suggestion-bot: "npm:^4.0.0"
+    suggestion-bot: "workspace:*"
     typescript: "catalog:"
   languageName: unknown
   linkType: soft
@@ -17408,19 +17408,21 @@ __metadata:
   languageName: node
   linkType: hard
 
-"suggestion-bot@npm:^4.0.0":
-  version: 4.0.3
-  resolution: "suggestion-bot@npm:4.0.3"
+"suggestion-bot@workspace:*, suggestion-bot@workspace:packages/suggestion-bot":
+  version: 0.0.0-use.local
+  resolution: "suggestion-bot@workspace:packages/suggestion-bot"
   dependencies:
     "@octokit/core": "npm:^7.0.0"
     "@octokit/plugin-rest-endpoint-methods": "npm:^17.0.0"
+    "@rnx-kit/scripts": "npm:*"
+    "@rnx-kit/tsconfig": "npm:*"
+    "@types/node": "npm:^24.0.0"
     azure-devops-node-api: "npm:^15.0.0"
     parse-diff: "npm:^0.11.0"
   bin:
     suggestion-bot: cli.js
-  checksum: 10c0/6a09741e8830ea205a1ead6c3191eb40c237e5859535c32fb139db7f495528fbf4e9dfe18cf9ac6f0bb3aa65cd6e99e73037633f6ce97423d65016d424c5640d
-  languageName: node
-  linkType: hard
+  languageName: unknown
+  linkType: soft
 
 "supports-color@npm:^5.3.0":
   version: 5.5.0

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"suggestion-bot": patch
 +---
++
 +Publish from rnx-kit