Skip to content

feat(yarn-plugin-ignore): Yarn plugin implementing the ignore: protocol#4065

Merged
JasonVMo merged 2 commits intomainfrom
tido/yarn-plugin-ignore
Apr 8, 2026
Merged

feat(yarn-plugin-ignore): Yarn plugin implementing the ignore: protocol#4065
JasonVMo merged 2 commits intomainfrom
tido/yarn-plugin-ignore

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented Mar 30, 2026

Description

Yarn plugin implementing the ignore: protocol

Test plan

Verify that node-gyp gets linked to the stub:

% ls node_modules/.store/fsevents-npm-2.3.3-ce9fb0ffae/node_modules/
total 0
fsevents@ -> ../package
node-gyp@ -> ../../../.generated/@rnx-kit/yarn-plugin-ignore-stub

Test coverage:

% yarn test --coverage
▶ IgnoreFetcher
  ✔ supports `ignore:` protocol (0.758375ms)
  ✔ returns `null` local path (0.077875ms)
✔ IgnoreFetcher (1.390375ms)
▶ IgnoreResolver
  ✔ supports `ignore:` protocol (0.830167ms)
  ✔ does not persist resolution (0.057875ms)
  ✔ binds descriptor (0.162708ms)
  ✔ returns no dependencies (0.423ms)
  ✔ returns one candidate (0.124292ms)
  ✔ returns the one candidate as satisfying (0.128334ms)
  ✔ resolves the stub (0.177792ms)
✔ IgnoreResolver (2.538167ms)
▶ stub package
  ✔ contains a valid manifest (0.825625ms)
  ✔ contains a valid main file (35.859875ms)
✔ stub package (37.291667ms)
✔ test/helper.ts (276.47275ms)
ℹ tests 12
ℹ suites 3
ℹ pass 12
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 303.278917
ℹ start of coverage report
ℹ ---------------------------------------------------------------------
ℹ file                 | line % | branch % | funcs % | uncovered lines
ℹ ---------------------------------------------------------------------
ℹ src                  |        |          |         |
ℹ  constants.ts        | 100.00 |   100.00 |  100.00 |
ℹ  IgnoreFetcher.ts    |  46.67 |   100.00 |   66.67 | 21-44
ℹ  IgnoreResolver.ts   | 100.00 |   100.00 |  100.00 |
ℹ ---------------------------------------------------------------------
ℹ all files            |  81.95 |   100.00 |   91.67 |
ℹ ---------------------------------------------------------------------
ℹ end of coverage report

@github-actions github-actions bot added the chore Improvements that don't directly affect features label Mar 30, 2026
@tido64 tido64 force-pushed the tido/yarn-plugin-ignore branch 2 times, most recently from 4ebc472 to 7f4efcc Compare March 30, 2026 14:48
@tido64 tido64 force-pushed the tido/yarn-plugin-ignore branch 3 times, most recently from 48ff97f to 8d3f201 Compare April 7, 2026 10:58
@tido64 tido64 marked this pull request as ready for review April 7, 2026 11:03
@tido64 tido64 force-pushed the tido/yarn-plugin-ignore branch from 875eb77 to ccc2bbc Compare April 7, 2026 12:33
@tido64 tido64 force-pushed the tido/yarn-plugin-ignore branch from ccc2bbc to 2c58dea Compare April 7, 2026 17:02
Copy link
Copy Markdown
Collaborator

@JasonVMo JasonVMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes on the resolver portion.

@tido64 tido64 force-pushed the tido/yarn-plugin-ignore branch from 6206a21 to 5c86f06 Compare April 8, 2026 12:37
@tido64 tido64 force-pushed the tido/yarn-plugin-ignore branch from 5c86f06 to 5ae0741 Compare April 8, 2026 12:40
@JasonVMo JasonVMo merged commit b85a882 into main Apr 8, 2026
15 checks passed
@JasonVMo JasonVMo deleted the tido/yarn-plugin-ignore branch April 8, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Improvements that don't directly affect features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants