Skip to content

Fix the CI pipeline. #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iclanton merged 3 commits into from
Feb 24, 2026
Merged

Fix the CI pipeline. #303

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a08009
Fix SSR crash: guard window.devicePixelRatio access in PeopleGrid
iclanton Feb 24, 2026
15c5d21
Address review: use BrowserOnly for devicePixelRatio in PeopleGrid
iclanton Feb 24, 2026
97a7fe3
Always use size=200
iclanton Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions websites/rushstack.io/src/components/PeopleGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ interface IGitHubCardProps {
person: IPersonJson;
}

const gitHubBaseUrl = 'https://github.com/';
const size: number = window.devicePixelRatio >= 2 ? 200 : 100;
const GITHUB_BASE_URL = 'https://github.com/';
const PROFILE_PHOTO_SIZE: number = 200;
Comment thread
iclanton marked this conversation as resolved.

/**
* Returns GitHub profile and avatar URLs for a given alias.
Expand All @@ -21,13 +21,13 @@ function getGitHubProfileInfo(githubAlias: string): { profileUrl: string; avatar
return false;
}

const urlBuilder = new URL(gitHubBaseUrl);
const urlBuilder = new URL(GITHUB_BASE_URL);

urlBuilder.pathname = githubAlias;
const profileUrl = urlBuilder.toString();

urlBuilder.pathname += '.png';
urlBuilder.searchParams.set('size', size.toString());
urlBuilder.searchParams.set('size', PROFILE_PHOTO_SIZE.toString());
const avatarUrl = urlBuilder.toString();

return { profileUrl, avatarUrl };
Expand Down