Address code review feedback: make workingDirectory required and add comprehensive tests

Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>

Author: Copilot

libraries/rush-lib/src/api/test/RushConfiguration.test.ts

@@ -77,7 +77,7 @@ describe(RushConfiguration.name, () => {
     expect(rushConfiguration.projectFolderMinDepth).toEqual(1);
     expect(rushConfiguration.hotfixChangeEnabled).toEqual(true);
 
-    expect(rushConfiguration.projects).toHaveLength(3);
+    expect(rushConfiguration.projects).toHaveLength(5);
 
     // "approvedPackagesPolicy" feature
     const approvedPackagesPolicy: ApprovedPackagesPolicy = rushConfiguration.approvedPackagesPolicy;

libraries/rush-lib/src/api/test/repo/apps/app1/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "app1",
+  "version": "1.0.0",
+  "description": "Test app 1"
+}

libraries/rush-lib/src/api/test/repo/apps/app2/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "app2",
+  "version": "1.0.0",
+  "description": "Test app 2"
+}

libraries/rush-lib/src/api/test/repo/common/config/rush/version-policies.json

@@ -0,0 +1,8 @@
+[
+  {
+    "definitionName": "lockStepVersion",
+    "policyName": "testPolicy",
+    "version": "1.0.0",
+    "nextBump": "minor"
+  }
+]

libraries/rush-lib/src/api/test/repo/rush-npm.json

@@ -28,7 +28,8 @@
       "packageName": "project1",
       "projectFolder": "project1",
       "reviewCategory": "third-party",
-      "tags": ["frontend", "ui"]
+      "tags": ["frontend", "ui"],
+      "versionPolicyName": "testPolicy"
     },
 
     {
@@ -43,7 +44,20 @@
       "packageName": "project3",
       "projectFolder": "project3",
       "reviewCategory": "prototype",
-      "tags": ["frontend"]
+      "tags": ["frontend"],
+      "versionPolicyName": "testPolicy"
+    },
+
+    {
+      "packageName": "app1",
+      "projectFolder": "apps/app1",
+      "reviewCategory": "first-party"
+    },
+
+    {
+      "packageName": "app2",
+      "projectFolder": "apps/app2",
+      "reviewCategory": "first-party"
     }
   ]
 }

libraries/rush-lib/src/cli/parsing/SelectionParameterSet.ts

@@ -73,7 +73,7 @@ export class SelectionParameterSet {
     selectorParsers.set('tag', new TagProjectSelectorParser(rushConfiguration));
     selectorParsers.set('version-policy', new VersionPolicyProjectSelectorParser(rushConfiguration));
     selectorParsers.set('subspace', new SubspaceSelectorParser(rushConfiguration));
-    selectorParsers.set('path', new PathProjectSelectorParser(rushConfiguration));
+    selectorParsers.set('path', new PathProjectSelectorParser(rushConfiguration, process.cwd()));
 
     this._selectorParserByScope = selectorParsers;
 

libraries/rush-lib/src/logic/selectors/PathProjectSelectorParser.ts

@@ -15,9 +15,9 @@ export class PathProjectSelectorParser implements ISelectorParser<RushConfigurat
   private readonly _rushConfiguration: RushConfiguration;
   private readonly _workingDirectory: string;
 
-  public constructor(rushConfiguration: RushConfiguration, workingDirectory?: string) {
+  public constructor(rushConfiguration: RushConfiguration, workingDirectory: string) {
     this._rushConfiguration = rushConfiguration;
-    this._workingDirectory = workingDirectory ?? process.cwd();
+    this._workingDirectory = workingDirectory;
   }
 
   public async evaluateSelectorAsync({

libraries/rush-lib/src/logic/selectors/test/PathProjectSelectorParser.test.ts

@@ -62,6 +62,19 @@ describe(PathProjectSelectorParser.name, () => {
     expect(packageNames).toContain('project3');
   });
 
+  it('should select multiple projects from a shared subfolder', async () => {
+    const result = await parser.evaluateSelectorAsync({
+      unscopedSelector: 'apps',
+      terminal,
+      parameterName: '--only'
+    });
+
+    const projects = Array.from(result);
+    expect(projects).toHaveLength(2);
+    const packageNames = projects.map((p) => p.packageName).sort();
+    expect(packageNames).toEqual(['app1', 'app2']);
+  });
+
   it('should select project from specified directory', async () => {
     const project1Path = path.join(rushConfiguration.rushJsonFolder, 'project1');
     const parserWithCustomCwd = new PathProjectSelectorParser(rushConfiguration, project1Path);

libraries/rush-lib/src/logic/selectors/test/VersionPolicyProjectSelectorParser.test.ts

@@ -22,10 +22,23 @@ describe(VersionPolicyProjectSelectorParser.name, () => {
     parser = new VersionPolicyProjectSelectorParser(rushConfiguration);
   });
 
-  it('should return empty completions when no version policies exist', () => {
-    // The test fixture doesn't have version policies configured
+  it('should return completions for version policies', () => {
     const completions = Array.from(parser.getCompletions());
-    expect(completions).toHaveLength(0);
+    expect(completions.length).toBeGreaterThan(0);
+    expect(completions).toContain('testPolicy');
+  });
+
+  it('should select projects by version policy', async () => {
+    const result = await parser.evaluateSelectorAsync({
+      unscopedSelector: 'testPolicy',
+      terminal,
+      parameterName: '--only'
+    });
+
+    const projects = Array.from(result);
+    expect(projects).toHaveLength(2);
+    const packageNames = projects.map((p) => p.packageName).sort();
+    expect(packageNames).toEqual(['project1', 'project3']);
   });
 
   it('should throw error for non-existent version policy', async () => {