[rush] Consolidate pnpm options handling into InstallHelpers.resolvePnpmSettings (#5880)

* More cleanup.

* [rush] Consolidate pnpm options handling into InstallHelpers.resolvePnpmSettings

Read the pnpm options in a single place that derives both the common package.json "pnpm" field and a populated PnpmWorkspaceFile, removing the duplicated pnpm-version gating between generateCommonPackageJsonAsync and WorkspaceInstallManager.prepareCommonTempAsync.

* Create a pnpmWorkspaceFileName constant.

* Get rid of some path.joins

* [rush] Add PnpmWorkspaceFile.loadAsync to read pnpm-workspace.yaml once

Replace the per-field loadPatchedDependenciesAsync/loadAllowBuildsAsync helpers with a single loadAsync that parses the file once and returns a populated PnpmWorkspaceFile, and use it from the rush-pnpm patch-commit and approve-builds commands.

* Add rush change file

* Rush change.

Author: iclanton

common/changes/@microsoft/rush/more-install-helpers-cleanup_2026-07-17-20-53-20.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@microsoft/rush"
+    }
+  ],
+  "packageName": "@microsoft/rush",
+  "email": "iclanton@users.noreply.github.com"
+}

common/reviews/api/rush-lib.api.md

@@ -1578,6 +1578,7 @@ export class RushConstants {
     static readonly pnpmSyncFilename: '.pnpm-sync.json';
     static readonly pnpmV3ShrinkwrapFilename: 'pnpm-lock.yaml';
     static readonly pnpmVirtualStoreFolderName: '.pnpm';
+    static readonly pnpmWorkspaceFileName: 'pnpm-workspace.yaml';
     static readonly projectImpactGraphFilename: 'project-impact-graph.yaml';
     static readonly projectRushFolderName: '.rush';
     static readonly projectShrinkwrapFilename: 'shrinkwrap-deps.json';

libraries/rush-lib/src/cli/RushPnpmCommandLineParser.ts

@@ -166,7 +166,7 @@ export class RushPnpmCommandLineParser {
     this._subspace = subspace;
 
     const workspaceFolder: string = subspace.getSubspaceTempFolderPath();
-    const workspaceFilePath: string = path.join(workspaceFolder, 'pnpm-workspace.yaml');
+    const workspaceFilePath: string = `${workspaceFolder}/${RushConstants.pnpmWorkspaceFileName}`;
 
     if (!FileSystem.exists(workspaceFilePath)) {
       this._terminal.writeErrorLine('Error: The PNPM workspace file has not been generated:');
@@ -545,9 +545,10 @@ export class RushPnpmCommandLineParser {
         let newGlobalPatchedDependencies: Record<string, string> | undefined;
         if (semver.gte(pnpmVersion, '11.0.0')) {
           // PNPM 11+ stores patchedDependencies in pnpm-workspace.yaml instead of the package.json "pnpm" field
-          newGlobalPatchedDependencies = await PnpmWorkspaceFile.loadPatchedDependenciesAsync(
-            `${subspaceTempFolder}/pnpm-workspace.yaml`
+          const workspaceFile: PnpmWorkspaceFile = await PnpmWorkspaceFile.loadAsync(
+            `${subspaceTempFolder}/${RushConstants.pnpmWorkspaceFileName}`
           );
+          newGlobalPatchedDependencies = workspaceFile.patchedDependencies;
         } else {
           // PNPM 10.x and earlier store patchedDependencies in the package.json "pnpm" field
           // Example: "C:\MyRepo\common\temp\package.json"
@@ -612,13 +613,10 @@ export class RushPnpmCommandLineParser {
 
         if (semver.gte(pnpmVersion, '11.0.0')) {
           // PNPM 11+ uses allowBuilds in pnpm-workspace.yaml instead of onlyBuiltDependencies in package.json
-          const workspaceYamlFilename: string = `${subspaceTempFolder}/pnpm-workspace.yaml`;
-          const yamlModule: typeof import('js-yaml') = await import('js-yaml');
-          const workspaceYamlContent: string = await FileSystem.readFileAsync(workspaceYamlFilename);
-          const workspaceYaml: { allowBuilds?: Record<string, boolean> } = (yamlModule.load(
-            workspaceYamlContent
-          ) ?? {}) as { allowBuilds?: Record<string, boolean> };
-          const newGlobalAllowBuilds: Record<string, boolean> | undefined = workspaceYaml?.allowBuilds;
+          const workspaceFile: PnpmWorkspaceFile = await PnpmWorkspaceFile.loadAsync(
+            `${subspaceTempFolder}/${RushConstants.pnpmWorkspaceFileName}`
+          );
+          const newGlobalAllowBuilds: Record<string, boolean> | undefined = workspaceFile.allowBuilds;
           const currentGlobalAllowBuilds: Record<string, boolean> | undefined =
             pnpmOptions?.globalAllowBuilds;
 

libraries/rush-lib/src/logic/RushConstants.ts

@@ -369,4 +369,9 @@ export class RushConstants {
    * The filename ("pnpm-sync.json") used to store the state of the pnpm sync command.
    */
   public static readonly pnpmSyncFilename: '.pnpm-sync.json' = '.pnpm-sync.json';
+
+  /**
+   * The filename ("pnpm-workspace.yaml") used to store the state of the pnpm workspace configuration.
+   */
+  public static readonly pnpmWorkspaceFileName: 'pnpm-workspace.yaml' = 'pnpm-workspace.yaml';
 }