Address code review: use Buffer.isBuffer for clearer body length check

Copilot · iclanton · web-flow · commit 66fcffcda388 · 2026-04-05T21:46:09.000Z
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/c103fb17-b8b1-4d02-88ba-9db236e9f48f Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>
diff --git a/rush-plugins/rush-http-build-cache-plugin/src/HttpBuildCacheProvider.ts b/rush-plugins/rush-http-build-cache-plugin/src/HttpBuildCacheProvider.ts
@@ -361,7 +361,7 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
       }
     }
 
-    const bodyLength: number | string = (body as Buffer | undefined)?.length ?? 'unknown';
+    const bodyLength: number | string = Buffer.isBuffer(body) ? body.length : 'unknown';
 
     terminal.writeDebugLine(`[http-build-cache] request: ${method} ${url} ${bodyLength} bytes`);
 

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {`
`361`	`361`	`}`
`362`	`362`	`}`
`363`	`363`
`364`		`- const bodyLength: number \| string = (body as Buffer \| undefined)?.length ?? 'unknown';`
	`364`	`+ const bodyLength: number \| string = Buffer.isBuffer(body) ? body.length : 'unknown';`
`365`	`365`
`366`	`366`	terminal.writeDebugLine(`[http-build-cache] request: ${method} ${url} ${bodyLength} bytes`);
`367`	`367`