address Ian's post-merge feedback on RUSH_QUIET_MODE handling from PR #5700

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/df565d26-3d49-47c6-8291-66cfb9e2c946

Author: Copilot

libraries/rush-lib/src/api/EnvironmentConfiguration.ts

@@ -625,7 +625,10 @@ export class EnvironmentConfiguration {
           }
 
           case EnvironmentVariableNames.RUSH_QUIET_MODE: {
-            // Accept both "true"/"false" string values and the standard "1"/"0" values
+            // Accept "true"/"false" string values in addition to the standard "1"/"0" values because
+            // install-run-rush.ts, RushCommandLineParser, and RushXCommandLine read this variable
+            // directly from process.env (before EnvironmentConfiguration is initialized) and also
+            // accept "true" as a truthy value. The two code paths must agree on accepted values.
             if (value === 'true' || value === 'false') {
               EnvironmentConfiguration._quietMode = value === 'true';
             } else {

libraries/rush-lib/src/cli/RushCommandLineParser.ts

@@ -63,7 +63,7 @@ import { InitSubspaceAction } from './actions/InitSubspaceAction';
 import { RushAlerts } from '../utilities/RushAlerts';
 import { initializeDotEnv } from '../logic/dotenv';
 import { measureAsyncFn } from '../utilities/performance';
-import { EnvironmentVariableNames } from '../api/EnvironmentConfiguration';
+import { EnvironmentConfiguration, EnvironmentVariableNames } from '../api/EnvironmentConfiguration';
 
 /**
  * Options for `RushCommandLineParser`.
@@ -221,10 +221,18 @@ export class RushCommandLineParser extends CommandLineParser {
       }
     }
 
-    const quietModeValue: string | undefined =
-      process.env[EnvironmentVariableNames.RUSH_QUIET_MODE];
-    if (quietModeValue === '1' || quietModeValue === 'true') {
-      return true;
+    // If EnvironmentConfiguration has already been initialized, use it to get the quiet mode value.
+    // Otherwise, read directly from process.env because this method may be called before dotenv
+    // files are loaded and EnvironmentConfiguration is validated (e.g. from Rush.launch()).
+    if (EnvironmentConfiguration.hasBeenValidated) {
+      if (EnvironmentConfiguration.quietMode) {
+        return true;
+      }
+    } else {
+      const quietModeValue: string | undefined = process.env[EnvironmentVariableNames.RUSH_QUIET_MODE];
+      if (quietModeValue === '1' || quietModeValue === 'true') {
+        return true;
+      }
     }
 
     return false;

libraries/rush-lib/src/cli/RushXCommandLine.ts

@@ -295,6 +295,8 @@ export class RushXCommandLine {
       }
     }
 
+    // This method is called at the start of launchRushXAsync(), before RushConfiguration.loadFromConfigurationFile()
+    // initializes EnvironmentConfiguration. We must read process.env directly here.
     const quietModeValue: string | undefined =
       process.env[EnvironmentVariableNames.RUSH_QUIET_MODE];
     if (quietModeValue === '1' || quietModeValue === 'true') {

libraries/rush-lib/src/scripts/install-run-rush.ts

@@ -15,15 +15,17 @@ const {
 import type { ILogger } from '../utilities/npmrcUtilities';
 
 const PACKAGE_NAME: string = '@microsoft/rush';
-const RUSH_PREVIEW_VERSION: string = 'RUSH_PREVIEW_VERSION';
-const RUSH_QUIET_MODE: string = 'RUSH_QUIET_MODE';
+const RUSH_PREVIEW_VERSION_ENV_VAR_NAME: string = 'RUSH_PREVIEW_VERSION';
+const RUSH_QUIET_MODE_ENV_VAR_NAME: string = 'RUSH_QUIET_MODE';
 const INSTALL_RUN_RUSH_LOCKFILE_PATH_VARIABLE: 'INSTALL_RUN_RUSH_LOCKFILE_PATH' =
   'INSTALL_RUN_RUSH_LOCKFILE_PATH';
 
 function _getRushVersion(logger: ILogger): string {
-  const rushPreviewVersion: string | undefined = process.env[RUSH_PREVIEW_VERSION];
+  const rushPreviewVersion: string | undefined = process.env[RUSH_PREVIEW_VERSION_ENV_VAR_NAME];
   if (rushPreviewVersion !== undefined) {
-    logger.info(`Using Rush version from environment variable ${RUSH_PREVIEW_VERSION}=${rushPreviewVersion}`);
+    logger.info(
+      `Using Rush version from environment variable ${RUSH_PREVIEW_VERSION_ENV_VAR_NAME}=${rushPreviewVersion}`
+    );
     return rushPreviewVersion;
   }
 
@@ -74,7 +76,9 @@ function _run(): void {
 
   let commandFound: boolean = false;
 
-  const quietModeEnvValue: string | undefined = process.env[RUSH_QUIET_MODE];
+  // This is a bootstrap script that runs before rush-lib is loaded. EnvironmentConfiguration is not
+  // available here, so we read the environment variable directly.
+  const quietModeEnvValue: string | undefined = process.env[RUSH_QUIET_MODE_ENV_VAR_NAME];
   let quiet: boolean = quietModeEnvValue === '1' || quietModeEnvValue === 'true';
 
   for (const arg of packageBinArgs) {